Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poor error message when version is incorrect #36

Closed
michaelhkay opened this issue Jun 7, 2021 · 1 comment
Closed

Poor error message when version is incorrect #36

michaelhkay opened this issue Jun 7, 2021 · 1 comment
Labels
is:bug Something isn't working

Comments

@michaelhkay
Copy link

Calling VersionInfo.getInstance("unknown") produces the error message "Invalid version number: Version number may be negative or greater than 255". I suspect "may not" was intended (or perhaps "may" should be "might"?), but that doesn't exactly capture the error either...

@NightOwl888
Copy link
Owner

Thanks for the report. You are correct, it should read:

private const string INVALID_VERSION_NUMBER_ =
    "Invalid version number: Version number may not be negative or greater than 255";

That is, based on the validation check that is occurring.

@NightOwl888 NightOwl888 added good first issue Good for newcomers is:bug Something isn't working up for grabs This issue is open to be worked on by anyone labels Jun 12, 2021
@NightOwl888 NightOwl888 removed good first issue Good for newcomers up for grabs This issue is open to be worked on by anyone labels Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants