response auto-validation of does not fail for methods that do not have apipie documentation

Author: elasti-ron

lib/apipie/application.rb

@@ -257,6 +257,7 @@ def reload_examples
 
     def json_schema_for_method_response(version, controller_name, method_name, return_code, allow_nulls)
       method = @resource_descriptions[version][controller_name].method_description(method_name)
+      raise NoDocumentedMethod.new(controller_name, method_name) if method.nil?
       @swagger_generator.json_schema_for_method_response(method, return_code, allow_nulls)
     end
 

lib/apipie/errors.rb

@@ -72,4 +72,15 @@ def to_s
       "Response does not match swagger schema (#{@controller_name}##{@method_name} #{@response_code}): #{@error_messages}\nSchema: #{JSON(@schema)}\nReturned object: #{@returned_object}"
     end
   end
+
+  class NoDocumentedMethod < Error
+    def initialize(controller_name, method_name)
+      @method_name = method_name
+      @controller_name = controller_name
+    end
+
+    def to_s
+      "There is no documented method #{@controller_name}##{@method_name}"
+    end
+  end
 end

lib/apipie/rspec/response_validation_helper.rb

@@ -103,8 +103,9 @@ def schema_validation_errors_for_response
       error_object = Apipie::ResponseDoesNotMatchSwaggerSchema.new(controller_name, action_name, response.code, error_list, schema, response.body)
 
       [schema, error_list, error_object]
+    rescue Apipie::NoDocumentedMethod
+      [nil, [], nil]
     end
-
   end
 
   include Apipie::ControllerValidationHelpers

spec/dummy/app/controllers/pets_controller.rb

@@ -244,6 +244,12 @@ def return_and_validate_type_mismatch
     render :json => result
   end
 
+  #-----------------------------------------------------------
+  # A method with no documentation
+  #-----------------------------------------------------------
+  def undocumented_method
+    render :json => {:result => "ok"}
+  end
 
   #-----------------------------------------------------------
   # A method which has a response with a missing field

spec/dummy/config/routes.rb

@@ -41,6 +41,7 @@
 
       get "/pets/returns_response_with_valid_array" => "pets#returns_response_with_valid_array"
       get "/pets/returns_response_with_invalid_array" => "pets#returns_response_with_invalid_array"
+      get "/pets/undocumented_method" => "pets#undocumented_method"
     end
 
     apipie

spec/lib/swagger/response_validation_spec.rb

@@ -79,6 +79,11 @@
     it "raises exception when a response field has the wrong type and auto validation is turned on" do
       expect { get :return_and_validate_type_mismatch, {format: :json} }.to raise_error(Apipie::ResponseDoesNotMatchSwaggerSchema)
     end
+
+    it "does not raise an exception when calling an undocumented method" do
+      expect { get :undocumented_method, {format: :json} }.not_to raise_error
+    end
+
   end