Skip to content

Conversation

@jjj120
Copy link

@jjj120 jjj120 commented Apr 5, 2024

I added download retries if some problem is raised during the download of an image.
I also added a days-back option for memories-v1, so if you only want to download the newest memories, not all are requested.

And I have another question: Logging in with my austrian number does not work because the google api-key has expired. Does anyone know what could be done about that?

@michielree
Copy link

Heads up: the API key in my pull request should fix your login issue #3

@jjj120
Copy link
Author

jjj120 commented Apr 10, 2024

@michielree thanks!

@NicoWeio
Copy link
Owner

My new semester just started and everything is chaotic, but hopefully, I can sort this out next week. You can expect quicker response times after that.

@NicoWeio
Copy link
Owner

Thanks for your contribution!
How about we use tenacity for retrying, though? Yes, it is another dependency, but would facilitate future changes and additions in terms of retry logic.
If you're not happy with this suggestion or don't want to do it, I'd go ahead and merge this as-is and keep tenacity in the backlog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants