-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Adds Portuguese translations #1493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! Just one comment as to the failure.
"name": "Nome", | ||
"email": "O email", | ||
"roles": "Papéis", | ||
"created-on": "Data de criação}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this is the cause of the failure. The messageformat parser uses the brackets for special reasons, so you can't use them in this way unfortunately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for locating the error.
Thanks for the review. I'll still be doing some revision of the translation before moving this out of draft. Would be great to know what would be needed besides the translation itself for this to be incorporated to the project. |
FWIW this is the error CI is reporting:
However, adding translations to v2 isn't really practical since there's no UI switcher for languages and it's hard coded to english, despite the underlying support for language files. |
PR is now considered stale. If you want to keep it open, please comment 👍 |
CI Error:
|
PR is now considered stale. If you want to keep it open, please comment 👍 |
We have a big need for this to be translated to Portuguese, as we intend various rural communities, with users new to the digital world, to be able to use this on their local networks.
I've started by adding translations to the "i18n/messages.json" file. But there's nowhere in the UI for language to be changed, and I didn't find in any part of the code translations to be changed based on browser language.
How can we start the process of adding other languages to the project?