Enable ESL support in Fallout 4 VR#23199
Conversation
Fixes Nexus-Mods#18789 Adds parity with Skyrim VR.
This is probably the better way, but will copy Skyrim VR for simplicity until Health Checks are easier to create.
|
@Aragas Thanks for approving. This would be better served as a Health Check item that appears only if the player has a light plugin installed, but I'm not sure how to add those yet - and Vortex built from source won't start up on my PC. Some kind of "DuckDB" version conflict denying it access to its own state files. |
IDCs
left a comment
IDCs
left a comment
There was a problem hiding this comment.
You're using selectors yet you didn't import it from vortex-api which will result in a referenceError
Also SkyrimVR is listening for the did-deploy event to scan for pre-existing ESL enablers. That should be mimicked as well.
Please test code before submitting a PR - I get that you can't build it on your end, but at least test it through the dynamic plugins pattern.
What's the need for the scan? Does it need to run every time? Maybe it could be a migration as any ESL-enabler installed after the update will have the flag anyway. |
|
It's meant to capture ESL enablers that are already installed - FO4VR ESL enabler has been out for months, so it's safe to assume users already have it installed. A migration is fine, but make sure it's tested. |
|
This PR has conflicts. You need to rebase the PR before it can be merged. |
|
This PR doesn't have conflicts anymore. It can be merged after all status checks have passed and it has been reviewed. |
3 participants
Fixes #18789
Adds parity with Skyrim VR.