You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Description TestBlockHashAnnounce is a test from HIVE devp2p eth protocol tests
Steps to Reproduce
In order to replicate the behavior, please provide a detailed list of steps:
Go to Actions -> Hive tests
Choose test suite: devp2p, limit: eth
TestBlockHashAnnounce is failing
Additional context
This test is failing, because for block headers without transactions and uncles (TxRoot = Keccak.EmptyTreeHash, UncleRoot = Keccak.EmptyTreeHash) we are requesting body. Test is expecting us to not request it, as from roots we know, that there are no transactions or uncles, so we can just add empty body.
It was fixed in the past: #3916
But it was failing HIVE engine tests so was reverted before the merge: https://github.com/NethermindEth/nethermind/pull/4463/files#diff-93f65ec12db68833d8c83643b5074a15f803171d26c4aed24415e1927e4e5892
Now we should fix it to pass both eth protocol and engine HIVE tests
The text was updated successfully, but these errors were encountered:
Description
TestBlockHashAnnounce
is a test from HIVE devp2p eth protocol testsSteps to Reproduce
In order to replicate the behavior, please provide a detailed list of steps:
Actions
->Hive tests
devp2p
, limit:eth
TestBlockHashAnnounce
is failingAdditional context
This test is failing, because for block headers without transactions and uncles (TxRoot = Keccak.EmptyTreeHash, UncleRoot = Keccak.EmptyTreeHash) we are requesting body. Test is expecting us to not request it, as from roots we know, that there are no transactions or uncles, so we can just add empty body.
It was fixed in the past:
#3916
But it was failing HIVE engine tests so was reverted before the merge:
https://github.com/NethermindEth/nethermind/pull/4463/files#diff-93f65ec12db68833d8c83643b5074a15f803171d26c4aed24415e1927e4e5892
Now we should fix it to pass both eth protocol and engine HIVE tests
The text was updated successfully, but these errors were encountered: