Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce SyncMode config property #4008

Open
dceleda opened this issue May 8, 2022 · 2 comments · May be fixed by #4273
Open

Introduce SyncMode config property #4008

dceleda opened this issue May 8, 2022 · 2 comments · May be fixed by #4273

Comments

@dceleda
Copy link
Contributor

dceleda commented May 8, 2022

Suggested by @LukaszRozmej
Could we change to have one property SyncMode with values from enumeration FullSync, FastSync, PivotSync, SnapSync instead of bool flags FastSync, FastBlocks, SnapSync? Those are now exclusive flags and make configuration confusing.

Additionally:
The entire application code should not use old properties.
The properties should be marked as deprecated, setting them should cause a warning to be displayed

@smartprogrammer93
Copy link
Contributor

FullSync, FastSync, PivotSync, SnapSync
Cover almost all cases but what about SnapSync with FastBlock as well? SnapPivotSync maybe?

@smartprogrammer93
Copy link
Contributor

Also, how do we go about being backwards compatible? Meaning, if someone updated nethermind to a newer version using an old config file that has the bool flags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants