ArgoEvents.publish attempts to make requests even when url is None

[emilyselwood]

We have been seeing a bunch of error messages at the ends of our steps like:

Unable to publish Argo Event (metaflow.ExportFlow.start): unknown url type: 'None'

These were happening at the same time as other errors so we spent a bunch of time figuring out what they meant. I think I've tracked down to the publish method in argo_events. We have not set the ARGO_EVENTS_WEBHOOK_URL so None is being passed along to the request which fails.

metaflow/metaflow/plugins/argo/argo_events.py

Line 125 in 39524f7

self._url,

My guess is a check could be added to the function that forces an early return if self._url is None, preventing it attempting to make a http request that will fail. I'd be happy to make that change if people agree that this is whats happening?

[savingoyal]

Thanks for opening the issue. Silently returning can mask config-related issues where the user expects an event to be emitted. A work-around in your case could be to submit the flows to argo-workflows using the --no-auto-emit-argo-events flag. Would that work?