Skip to content

Commit 65efef2

Browse files
author
Nissan Pow
committed
fix
1 parent 8656432 commit 65efef2

File tree

1 file changed

+10
-7
lines changed

1 file changed

+10
-7
lines changed

test/data/s3/s3_data.py

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -197,21 +197,22 @@ def data(self):
197197

198198
@property
199199
def url(self):
200-
return self.key
200+
"""Returns the full S3 URL including the S3ROOT prefix."""
201+
return os.path.join(S3ROOT, self.key)
201202

202203

203204
def _format_test_cases(dataset, meta=None, ranges=None):
204205
cases = []
205206
ids = []
206207
for prefix, filespecs in dataset:
207208
objs = [RandomFile(prefix, fname, size) for fname, size in filespecs.items()]
208-
objs = {obj.url: (obj, None, None) for obj in objs}
209+
objs = {obj.key: (obj, None, None) for obj in objs}
209210
if meta:
210211
# We generate one per meta info
211212
for metaname, (content_type, usermeta) in meta.items():
212213
objs.update(
213214
{
214-
"%s_%s" % (obj.url, metaname): (obj, content_type, usermeta)
215+
"%s_%s" % (obj.key, metaname): (obj, content_type, usermeta)
215216
for (obj, _, _) in objs.values()
216217
}
217218
)
@@ -519,11 +520,12 @@ def _do_upload(prefix, filespecs, meta=None):
519520
print("Test data case %s: uploaded to %s" % (prefix, f.url))
520521
if meta is not None:
521522
for metaname, metainfo in meta.items():
522-
new_url = "%s_%s" % (f.url, metaname)
523-
url = urlparse(new_url)
523+
new_key = "%s_%s" % (f.key, metaname)
524+
full_new_url = os.path.join(S3ROOT, new_key)
525+
url = urlparse(full_new_url)
524526
print(
525527
"Test data case %s: upload to %s started"
526-
% (prefix, new_url)
528+
% (prefix, full_new_url)
527529
)
528530
extra = {}
529531
content_type, user_meta = metainfo
@@ -541,7 +543,8 @@ def _do_upload(prefix, filespecs, meta=None):
541543
ExtraArgs=extra,
542544
)
543545
print(
544-
"Test data case %s: uploaded to %s" % (prefix, new_url)
546+
"Test data case %s: uploaded to %s"
547+
% (prefix, full_new_url)
545548
)
546549

547550
for prefix, filespecs in BIG_DATA + FAKE_RUN_DATA:

0 commit comments

Comments
 (0)