Skip to content
This repository was archived by the owner on Sep 3, 2025. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/dispatch/signal/service.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import json
from datetime import datetime, timedelta, timezone
from typing import Optional
from typing import Optional, Union

from pydantic.error_wrappers import ErrorWrapper, ValidationError
from sqlalchemy import desc, asc
Expand All @@ -18,6 +18,7 @@
from dispatch.tag import service as tag_service
from dispatch.workflow import service as workflow_service
from dispatch.entity.models import Entity
from dispatch.models import PrimaryKey

from .models import (
Signal,
Expand Down Expand Up @@ -207,7 +208,7 @@ def get_signal_instance(
)


def get(*, db_session: Session, signal_id: int) -> Optional[Signal]:
def get(*, db_session: Session, signal_id: Union[PrimaryKey, str]) -> Optional[Signal]:
"""Gets a signal by id or external_id."""
signal = db_session.query(Signal).filter(Signal.id == signal_id).one_or_none()
if not signal:
Expand Down
3 changes: 2 additions & 1 deletion src/dispatch/signal/views.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import logging
from typing import Union

from fastapi import APIRouter, BackgroundTasks, HTTPException, Request, Response, status, Depends
from pydantic.error_wrappers import ErrorWrapper, ValidationError
Expand Down Expand Up @@ -256,7 +257,7 @@ def get_signals(common: CommonParameters):


@router.get("/{signal_id}", response_model=SignalRead)
def get_signal(db_session: DbSession, signal_id: PrimaryKey):
def get_signal(db_session: DbSession, signal_id: Union[str, PrimaryKey]):
"""Gets a signal by its id."""
signal = get(db_session=db_session, signal_id=signal_id)
if not signal:
Expand Down