Merge release branch 4.19 to 4.20

* 4.19:
  Restrict the migration of volumes attached to VMs in Starting state (apache#9725)

Author: DaanHoogland

server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java

@@ -3268,6 +3268,7 @@ public Volume migrateVolume(MigrateVolumeCmd cmd) {
         VMInstanceVO vm = null;
         if (instanceId != null) {
             vm = _vmInstanceDao.findById(instanceId);
+            checkVmStateForMigration(vm, vol);
         }
 
         // Check that Vm to which this volume is attached does not have VM Snapshots
@@ -3465,6 +3466,22 @@ public Volume migrateVolume(MigrateVolumeCmd cmd) {
         return orchestrateMigrateVolume(vol, destPool, liveMigrateVolume, newDiskOffering);
     }
 
+    private void checkVmStateForMigration(VMInstanceVO vm, VolumeVO vol) {
+        List<State> suitableVmStatesForMigration = List.of(State.Stopped, State.Running, State.Shutdown);
+
+        if (!suitableVmStatesForMigration.contains(vm.getState())) {
+            s_logger.debug(String.format(
+                    "Unable to migrate volume: [%s] Id: [%s] because the VM: [%s] Id: [%s] is in state [%s], which is not supported for migration.",
+                    vol.getName(), vol.getId(), vm.getInstanceName(), vm.getUuid(), vm.getState()
+            ));
+
+            throw new CloudRuntimeException(String.format(
+                    "Volume migration is not allowed when the VM is in the %s state. Supported states are: %s.",
+                    vm.getState(), suitableVmStatesForMigration
+            ));
+        }
+    }
+
     private boolean isSourceOrDestNotOnStorPool(StoragePoolVO storagePoolVO, StoragePoolVO destinationStoragePoolVo) {
         return storagePoolVO.getPoolType() != Storage.StoragePoolType.StorPool
                 || destinationStoragePoolVo.getPoolType() != Storage.StoragePoolType.StorPool;