Skip to content

Conversation

btea
Copy link
Contributor

@btea btea commented Apr 13, 2025

这个 PR 做了什么? (简要描述所做更改)
vite构建vue3项目,打包内容 taro.js 和 vendors.js 会出现循环引用,导致报错。

这个 PR 是什么类型? (至少选择一个)

  • 错误修复(Bugfix) issue: fix #
  • 新功能(Feature)
  • 代码重构(Refactor)
  • TypeScript 类型定义修改(Typings)
  • 文档修改(Docs)
  • 代码风格更新(Code style update)
  • 其他,请描述(Other, please describe):

这个 PR 涉及以下平台:

  • 所有小程序
  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 字节跳动小程序
  • QQ 轻应用
  • 京东小程序
  • 快应用平台(QuickApp)
  • Web 平台(H5)
  • 移动端(React-Native)
  • 鸿蒙(harmony)

Summary by CodeRabbit

  • Bug Fixes

    • 解决了打包过程中可能因依赖分组不当而导致的循环依赖问题,提升了 Vue 3 项目构建时的稳定性。
  • Refactor

    • 优化了依赖分块逻辑,对库的识别和分组进行了改进,从而提高了整体构建流程的效率与可靠性。

Copy link

coderabbitai bot commented Apr 13, 2025

Walkthrough

本次修改在 packages/taro-vite-runner/src/mini/config.ts 文件中对 getManualChunks 函数进行了调整。新增了一个正则表达式数组 babelDeps 用于检测模块路径中是否包含 @babel,并在处理 Vue3 分支时增加判断逻辑:若模块 ID 匹配该正则,则返回 'babelHelpers',以避免在打包过程中产生循环引用问题。

Changes

文件 变化总结
packages/.../config.ts getManualChunks 中新增 babelDeps 正则数组;在 Vue3 分支中加入条件判断,当模块 ID 匹配时返回 'babelHelpers'

Sequence Diagram(s)

sequenceDiagram
  participant M as 模块
  participant F as getManualChunks
  M ->> F: 传入模块ID
  F ->> F: 判断当前框架是否为 Vue3
  alt 框架为 Vue3
      F ->> F: 检查模块ID是否匹配 babelDeps
      alt 匹配
          F -->> M: 返回 'babelHelpers'
      else 不匹配
          F -->> M: 执行常规逻辑
      end
  else 非 Vue3
      F -->> M: 按常规流程处理
  end
Loading

Poem

我是一只小兔子,跳跃在代码林间,
寻找 Babel 依赖,细心且敏锐。
正则如星光闪烁,点亮了前行的路,
避免循环引用,代码变得清晰明亮。
快乐编程,跳跃中迎接新一天!

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)
  • We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5b53c7c and f093ccd.

📒 Files selected for processing (1)
  • packages/taro-vite-runner/src/mini/config.ts (2 hunks)
🔇 Additional comments (2)
packages/taro-vite-runner/src/mini/config.ts (2)

169-169: 新增变量 babelDeps 用于匹配 Babel 相关依赖

这里新增了一个正则表达式数组,用于匹配 node_modules 中 @babel 相关的依赖路径。


190-191: 解决 Vue3 项目中的循环引用问题

这项更改很好地解决了 Vue3 项目在 Vite 构建过程中可能出现的循环引用问题。通过将 Babel 相关依赖单独打包到 'babelHelpers' chunk 中,避免了它们被包含在 vendors 中从而导致与 taro chunk 之间的循环依赖。注释清晰地解释了问题的原因和解决方案。

此修复针对性强,不影响其他框架的构建逻辑,是一个很好的定向解决方案。

✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@btea btea closed this Apr 13, 2025
@btea btea force-pushed the fix/vite-mini-config branch from 36685bf to 5b53c7c Compare April 13, 2025 03:23
@btea btea reopened this Apr 13, 2025
Copy link

codecov bot commented Apr 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.70%. Comparing base (5b53c7c) to head (f093ccd).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #17541   +/-   ##
=======================================
  Coverage   57.70%   57.70%           
=======================================
  Files         469      469           
  Lines       26551    26551           
  Branches     5859     5858    -1     
=======================================
  Hits        15321    15321           
+ Misses       9608     9598   -10     
- Partials     1622     1632   +10     
Flag Coverage Δ
taro-cli 72.37% <ø> (ø)
taro-runtime 59.87% <ø> (ø)
taro-web 49.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 12 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yoyo837 yoyo837 merged commit 5e4de56 into NervJS:main Apr 13, 2025
37 checks passed
@btea btea deleted the fix/vite-mini-config branch April 13, 2025 04:49
This was referenced Apr 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants