Proc attribute integer literals... #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello! I ran into this issue when following along with the tutorials. Firstly they are amazing and truly helpful in the GL space. I've really loved them. So thank you. My guess is that this is due to a change in rustc since the tutorials were posted. Basically this is a simple change to support integer literals on top of string literals in the procedural macro attributes.
|
Thank you! Let's keep this PR here as a reminder for me to review and update the tutorial. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! I ran into this issue when following along with the tutorials.
Firstly they are amazing and truly helpful in the GL space. I've really loved them. So thank you.
My guess is that this is due to a change in rustc since the tutorials were posted. Basically this is a simple change to support integer literals on top of string literals in the procedural macro attributes.