Skip to content

Several option flags #1757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Several option flags #1757

wants to merge 4 commits into from

Conversation

antonrogov
Copy link

  • simple_headers (default false) - use a simple line instead of windows for headers. Header window didn't close for me occasionally and stick until vim is closed.
  • force_if_includes (default true) - for some reason pushing to another remote branch (different name, not an upstream etc) with --force-with-lease didn't work for me if --force-if-includes was set. Also an option to opt out probably shouldn't hurt.
  • log_view_esc_close (default true) - I'd like to keep things consistent and use the same "Close" binding for all buffers and also keep spamming esc in log view without it closing
  • hard_reset_backup (default true) - ability to turn those commits off

@antonrogov antonrogov changed the title Several option flags and upstream push/rebase fixes Several option flags Jun 5, 2025
@antonrogov antonrogov force-pushed the master branch 3 times, most recently from a57ac3e to 2329c7b Compare June 5, 2025 12:32
@CKolkey
Copy link
Member

CKolkey commented Jun 5, 2025

I think some extra changes are sneaking in on accident because you are opening a PR from your master to mine - you could make a branch on your fork to be more selective about what changes are included here :)

@antonrogov
Copy link
Author

Sorry, yes :) Added all the changes in one batch first and then split into this one, #1759 and #1758 (both from separate branches), but forgot one commit - removed and re-pushed. Also just realised it's not needed since there's neogit.action(..) already

@CKolkey
Copy link
Member

CKolkey commented Jun 5, 2025

No worries. I'll try to make some time to review this all soon ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants