Missing actions while rebasing

[aleprovencio]

Description

Before the the last big changes on this repo there used to be a rebase menu on NeogitStatus while there was a rebase happening. There we could see the current commit and apply actions like skip, abort, continue and so on.
I don't see it anymore, is there a new workflow?

Neovim version

NVIM v0.9.1
Build type: Release
LuaJIT 2.1.0-beta3

Operating system and version

ArchLinux

Steps to reproduce

1. go to NeogitStatus
2. begin a rebase (ex: ri)

Expected behavior

There should be a rebase menu while at it

Actual behavior

It's not there

Minimal config

vim.cmd([[set runtimepath=$VIMRUNTIME]])
vim.cmd([[set packpath=/tmp/nvim/site]])
local package_root = "/tmp/nvim/site/pack"
local install_path = package_root .. "/packer/start/packer.nvim"
local function load_plugins()
  require("packer").startup({
    {
      "wbthomason/packer.nvim",
      {
        "TimUntersberger/neogit",
        requires = {
          { "nvim-lua/plenary.nvim" },
          { "sindrets/diffview.nvim" },
        },
        config = function()
          print("loaded neogit")
          require("neogit").setup()
        end,
      },
    },
    config = {
      package_root = package_root,
      compile_path = install_path .. "/plugin/packer_compiled.lua",
      display = { non_interactive = true },
    },
  })
end
if vim.fn.isdirectory(install_path) == 0 then
  print("Installing neogit and dependencies.")
  vim.fn.system({ "git", "clone", "--depth=1", "https://github.com/wbthomason/packer.nvim", install_path })
end
load_plugins()
require("packer").sync()

[CKolkey]

It still works, but you need to refresh the buffer manually with <c-r>. I've got a WIP branch that'll make this experience nicer. Can you try a manual refresh during a rebase just to make sure thats the issue? Otherwise we can try another approach.

It's also slightly different between ri and rp - the i is interactive, so should open a new buffer next to the status buffer. Is that not happening?

[aleprovencio]

You're right, for ri its different and the buffer does appear.

However testing with re (rebase elsewhere) it just won't work, even with a manual <c-r>.

[aleprovencio]

I don't know if this has something to do with the last commits, but after updating neogit today this is no longer an issue for me, don't even need the manual <c-r>!

I'll leave this open if you wanna add something else, but feel free to close .

[CKolkey]

I don't... think so..? But good!

[aleprovencio]

Unfortunately the same problem is happening again today .... I'm clueless 😞

[CKolkey]

Do you mind making a recording?

[aleprovencio]

Sure, here I try rebasing with re, also tried to <c-r> during the process

output.mp4

[CKolkey]

Ok, really helpful. Can you show me the value of := require("neogit.lib.git.repository").rebase when you are mid-rebase?

[CKolkey]

And, if it's not too much trouble, could you try with #614 that branch and let me know if the issue still happens.

[aleprovencio]

Ok, really helpful. Can you show me the value of := require("neogit.lib.git.repository").rebase when you are mid-rebase?

this:

{
  items = {}
}

And, if it's not too much trouble, could you try with #614 that branch and let me know if the issue still happens.

NeogitStatus shows an empty window here

[CKolkey]

...cool. Alright, thats great, thanks. I'll try and figure out whats up.

[CKolkey]

So... unfortunately, it seems to work just fine for me.

So, maybe something else is going on. Let's try this. Run neovim with NEOGIT_LOG_FILE=true and NEOGIT_LOG_LEVEL=trace in your env. Do the rebase and get to the bad state, then close neovim. You can get the log filepath via := require("neogit").get_log_file_path(), and post it here. Maybe that'll shed some light on whats going on.