Integration with diffview

[ericsunplus]

Hi community,

I want the neogit diff show as diffview style. In the README.md. It indicates a configuration

neogit.setup {
  integrations = {
    ...
    -- Neogit only provides inline diffs. If you want a more traditional way to look at diffs, you can use `diffview`.
    -- The diffview integration enables the diff popup.
    --
    -- Requires you to have `sindrets/diffview.nvim` installed.
    diffview = nil,
    ...
}

However after I set this, my diff is still shown as a inline diff way instead of a diffview side by side style. I open a NeogitLogView window first then press <CR> on one of the commit, this is what I get

I can achieve what I want by :DiffviewOpen <commit>^!. But this behavior is not "integrated" to neogit. Can anyone point out what may be missing in my configuration?

My full neogit config is as the following

return {
    "NeogitOrg/neogit",
    dependencies = {
        "nvim-lua/plenary.nvim",
        "sindrets/diffview.nvim",
    },
    config = function()
        require('neogit').setup {
            integrations = {
                diffview = true
            }
        } 
        vim.keymap.set('n', '<Leader>g', ':Neogit<CR>')
        vim.keymap.set('n', '<Leader>gh', ':DiffviewFileHistory ')
    end
}

[CKolkey]

Ah, perhaps the issue here is on how it's integrated. The diffview integration is for diffing via the diff popup (d). The status buffer (the view you are asking about) only offers inline diffs, not side-by-side.

This makes staging/unstaging/discarding individual lines possible, which is handy.

[ericsunplus]

Hi @CKolkey , thank you for the quick response. I think I would have to made a customized mapping to trigger this

        vim.keymap.set("n", "<Leader>dv", function()
            local sha = vim.fn.expand("<cword>")
            print("DiffviewOpen " .. sha .. "^!")
            vim.cmd("DiffviewOpen " .. sha .. "^!")
        end)

Is the NeogitLogView a status buffer? I see in the README.md mentioning about "log_view". Should I add such mapping to "status" or "log_view"?

[CKolkey]

"log_view" is what is opened via the log popup (so ll lc, etc). the status buffer is what is visible with :Neogit

[ericsunplus]

OK. I am just add a global mapping and it works perfectly. Thank you for the great plugin