Skip to content

Conversation

@joschmitt
Copy link
Collaborator

Necessary for thofma/Hecke.jl#1370 (assuming we really want to go down this rabbit hole).

@codecov
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0ef1f6a) 87.17% compared to head (08cd804) 87.17%.
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1583      +/-   ##
==========================================
- Coverage   87.17%   87.17%   -0.01%     
==========================================
  Files         115      115              
  Lines       29565    29565              
==========================================
- Hits        25773    25772       -1     
- Misses       3792     3793       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thofma
Copy link
Member

thofma commented Jan 29, 2024

I don't know all the ramifications, but this seem to not break anything, so let's get this in? @lgoettgens

@lgoettgens
Copy link
Member

I have no idea how macros work. So this is up to you.
If this gets merged and released, it will be available in Hecke once thofma/Hecke.jl#1371 is merged there.

@thofma
Copy link
Member

thofma commented Jan 29, 2024

The macro doesn't do anything. It is just some little trick to be able to sneak in a return inside the caller.

I will merge this for now.

@thofma thofma merged commit 8e269a6 into Nemocas:master Jan 29, 2024
@joschmitt joschmitt deleted the js/special branch February 1, 2024 12:53
ooinaruhugh pushed a commit to ooinaruhugh/AbstractAlgebra.jl that referenced this pull request Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants