-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add residue ring/field maps #1559
Conversation
@lgoettgens Have you also encountered the following:
???? Is it correct, that I cannot make this type print nicely? |
I am not sure I understand the question. Is it about the |
I noticed that the following two lines are only in import .Generic: EuclideanRingResidueRing # line 658
export EuclideanRingResidueRing # line 865 and they are not there for things like Does this help for your question? |
Reacting to my comment above and your commit in-between: I would have rather removed the import/export shenanigans for Or do I remember correctly that you wanted to merge the abstract type and the concrete type for both of these? In this case I think one could argue that in this case they should no longer live inside of |
There is no corresponding |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1559 +/- ##
==========================================
- Coverage 87.16% 87.11% -0.06%
==========================================
Files 115 114 -1
Lines 29412 29483 +71
==========================================
+ Hits 25638 25685 +47
- Misses 3774 3798 +24 ☔ View full report in Codecov by Sentry. |
- also purge `number_field`
- also purge `number_field`
No description provided.