Fix PrettyPrinting corner case, add more tests #1415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1415 +/- ##
==========================================
+ Coverage 85.74% 85.79% +0.04%
==========================================
Files 107 107
Lines 28771 28771
==========================================
+ Hits 24670 24683 +13
+ Misses 4101 4088 -13
... and 6 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Add some examples from the OSCAR dev docs to make sure they match
reality.
Also fix a bug where in some situations the pretty printing feature
caused a trailing 0 to be printed (e.g. when ending printing with
a `Dedent()`), as in this example:
julia> show(stdout, MIME"text/plain"(), F)
Number field with defining polynomial x^2 + 3
over rational field0
I tried to add a test case for this, but the issue only happens
with `stdout`, not with an `IOBuffer`
fingolfin
force-pushed
the
mh/fix-printing
branch
from
3c221ad
to
fbf4194
Compare
thofma
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some examples from the OSCAR dev docs to make sure they match reality.
Also fix a bug where in some situations the pretty printing feature caused a trailing 0 to be printed (e.g. when ending printing with a
Dedent()), as in this example:I tried to add a test case for this, but the issue only happens with
stdout, not with anIOBuffer