Skip to content

Commit 7ee19ff

Browse files
authored
Merge pull request ironhack-labs#2581 from ironhack-labs/uros/update/update-testing-instructions
Update the instructions for running the tests
2 parents 53bf3fd + 6903669 commit 7ee19ff

File tree

2 files changed

+45
-14
lines changed

2 files changed

+45
-14
lines changed

README.md

Lines changed: 33 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ When playing Clue, these three details are represented by a **suspect** card, a
1414

1515
- Fork this repo
1616
- Clone this repo
17-
- Visit the "Actions" tab in your fork, and enable workflows
1817

1918
<br>
2019

@@ -28,30 +27,28 @@ git commit -m "done"
2827
git push origin master
2928
```
3029

31-
- Create Pull Request so your TAs can check up your work.
30+
- Create a Pull Request so that your TAs can check your work.
3231

3332
<br>
3433

35-
## Remember our tests!
36-
37-
We will be working with automated tests again!
34+
## Instructions
3835

39-
Please, open your terminal, change directories into the root of the lab, and run `npm install` to install the test runner. Now, you can run the `npm run test:watch` command to run automated tests in _watch mode_. Open the resulting `lab-solution.html` file with the "Live Server" VSCode extension to always see the most up-to-date test results.
36+
You will be working in the `src/clue.js` file, which is already loaded in the `index.html` file.
4037

41-
_Hint:_
38+
To run the JavaScript code, open the `index.html` file using the [Live Server](https://marketplace.visualstudio.com/items?itemName=ritwickdey.LiveServer) VSCode extension.
4239

43-
```shell
44-
$ cd lab-javascript-clue
45-
$ npm install
46-
$ npm run test:watch
47-
```
40+
To see the output of your JavaScript code, open the [Console in the Developer Tools](https://developer.chrome.com/docs/devtools/open/#console).
4841

4942
<br>
43+
<hr>
5044

51-
## Instructions
45+
### Note about tests
46+
47+
This LAB is equipped with unit tests to provide automated feedback on your lab progress.
5248

53-
You will be working in the `src/clue.js` file. The test requirements (`tests/clue.spec.js`) will guide you in solving the following iterations.
49+
**After completing the basic iterations**, go to the **"Test Your Code"** section at the bottom. There you'll be asked to install the testing dependencies and run the tests to check how many tests your code is passing. Once you run the tests, correct your code to pass the failing tests.
5450

51+
<hr>
5552
<br>
5653

5754
### Iteration 1: Create the cards
@@ -127,6 +124,28 @@ Declare a function named `revealMystery` that receives an _envelope_ `object` (w
127124

128125
<br>
129126

127+
## Test Your Code
128+
129+
We will be working with automated tests again!
130+
131+
Please, open your terminal, change directories into the root of the lab, and run `npm install` to install the test runner. Now, you can run the `npm run test:watch` command to run automated tests in _watch mode_. Open the resulting `lab-solution.html` file with the "Live Server" VSCode extension to always see the most up-to-date test results.
132+
133+
_Hint:_
134+
135+
```shell
136+
$ cd lab-javascript-clue
137+
$ npm install
138+
$ npm run test:watch
139+
```
140+
141+
142+
143+
The test requirements (`tests/clue.spec.js`) will guide you in solving the remaining test requirements.
144+
145+
<br>
146+
147+
148+
130149
## Extra Resources
131150

132151
- [Data Structures: Objects and Arrays](http://eloquentjavascript.net/04_data.html)

index.html

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
<!DOCTYPE html>
2+
<html lang="en">
3+
<head>
4+
<meta charset="UTF-8">
5+
<meta http-equiv="X-UA-Compatible" content="IE=edge">
6+
<meta name="viewport" content="width=device-width, initial-scale=1.0">
7+
<title>LAB | JS Clue</title>
8+
</head>
9+
<body>
10+
<script src="./src/clue.js"></script>
11+
</body>
12+
</html>

0 commit comments

Comments
 (0)