Skip to content

feat: add unit tests and benchmark for isArray #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

umsungjun
Copy link
Contributor

  • Added isArray.test.ts for verifying functionality
  • Added isArray.bench.ts for performance comparison with lodash

Test
스크린샷 2025-05-02 오전 8 55 24

Benchmark
스크린샷 2025-05-02 오전 8 54 50

- Added isArray.test.ts for verifying functionality
- Added isArray.bench.ts for performance comparison with lodash
@umsungjun umsungjun requested a review from a team as a code owner May 1, 2025 23:56
Copy link
Contributor

github-actions bot commented May 1, 2025

✅ All utility modules are properly registered in index.ts and package.json exports!

Copy link
Contributor

github-actions bot commented May 1, 2025

Benchmark Results

Method Test Performance Comparison hidash ops/sec lodash@4.17.21 ops/sec
isArray src/isArray.bench.ts > isArray performance hidash is 8.90x faster 516.84 🏆 58.05

Note: Higher operations per second (ops/sec) numbers are better. Each test compares hidash vs lodash implementation.

⚠️ indicates where hidash is slower than lodash.

🏆 indicates the faster implementation.

View Full Benchmark Data
{
  "files": [
    {
      "filepath": "/home/runner/work/hidash/hidash/src/isArray.bench.ts",
      "groups": [
        {
          "fullName": "src/isArray.bench.ts > isArray performance",
          "benchmarks": [
            {
              "id": "1080123271_0_0",
              "name": "hidash",
              "rank": 1,
              "rme": 0.4986020908109256,
              "samples": [],
              "totalTime": 501.12418400000024,
              "min": 1.7790019999999913,
              "max": 2.820974000000035,
              "hz": 516.837958073881,
              "period": 1.9348424092664103,
              "mean": 1.9348424092664103,
              "variance": 0.006274613910987065,
              "sd": 0.07921246057904693,
              "sem": 0.004922022809438167,
              "df": 258,
              "critical": 1.96,
              "moe": 0.009647164706498807,
              "p75": 1.9460749999999507,
              "p99": 2.2879349999999476,
              "p995": 2.4738739999999666,
              "p999": 2.820974000000035,
              "sampleCount": 259,
              "median": 1.9275199999999586
            },
            {
              "id": "1080123271_0_1",
              "name": "lodash",
              "rank": 2,
              "rme": 0.16427843463533898,
              "samples": [],
              "totalTime": 516.7567079999994,
              "min": 17.065432999999985,
              "max": 17.442688999999973,
              "hz": 58.05439878295693,
              "period": 17.225223599999982,
              "mean": 17.225223599999982,
              "variance": 0.0057441461101094835,
              "sd": 0.07579014520443593,
              "sem": 0.013837324055020516,
              "df": 29,
              "critical": 2.045,
              "moe": 0.028297327692516954,
              "p75": 17.271789999999896,
              "p99": 17.442688999999973,
              "p995": 17.442688999999973,
              "p999": 17.442688999999973,
              "sampleCount": 30,
              "median": 17.226079000000027
            }
          ]
        }
      ]
    }
  ]
}

Last updated by GitHub Actions

Copy link
Contributor

@yceffort-naver yceffort-naver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for consistently contributing to hidash. Feel free to merge whenever you’re ready. 🚀

@umsungjun
Copy link
Contributor Author

@yceffort-naver

I have a question since I couldn't see the merge button, I was wondering how I should go about merging. Could you let me know the proper way to do it?

@yceffort-naver
Copy link
Contributor

Oh, sorry about that—I didn’t realize external contributors couldn’t see the merge button. I’ll go ahead and merge it myself. Thanks again! 😊

@yceffort-naver yceffort-naver merged commit 7353975 into NaverPayDev:main May 6, 2025
6 of 7 checks passed
@umsungjun
Copy link
Contributor Author

Yes, thank you as always 😊

@umsungjun umsungjun deleted the feat/isArray-test-benchmark branch May 6, 2025 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants