Skip to content

Shrinks99 → NatronGitHub in readme #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 20, 2025
Merged

Shrinks99 → NatronGitHub in readme #15

merged 3 commits into from
May 20, 2025

Conversation

Shrinks99
Copy link
Collaborator

@Shrinks99 Shrinks99 commented May 20, 2025

Changes

  • Reorders meta tags
  • Adds new opengraph image
  • Fixes readme links & badges
  • Open docs in new tab when clicked in nav

@Shrinks99 Shrinks99 requested a review from Songtech-0912 May 20, 2025 20:47
Copy link
Collaborator

@Songtech-0912 Songtech-0912 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Approved :)

@Songtech-0912 Songtech-0912 merged commit 9ca20ca into main May 20, 2025
1 of 2 checks passed
@Songtech-0912 Songtech-0912 deleted the fix-opengraph branch May 20, 2025 20:51
@rodlie
Copy link
Contributor

rodlie commented May 20, 2025

Still missing generic <meta name="description" content="...

Also, this needs to be fixed:

  <meta name="og:description" content="{% if page.description %}
      {{ page.description | strip_html | strip_newlines | truncate: 160 }}
    {% else %}
      {{ site.description }}
    {% endif %}">

{% whatever %} will generate newline, so you should move the logic outside the tag, or define something earlier and use that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants