Merge pull request #175 from NativeScript/romulowspp-readmepluginname

Romulowspp readmepluginname

Author: elena-p

seed-tests/e2e/setup.ts

@@ -4,9 +4,9 @@ const addContext = require('mochawesome/addContext');
 const testReporterContext = <ITestReporter>{};
 testReporterContext.name = "mochawesome";
 /**
- * This folder should be the one provided in mocha.opts. 
+ * This folder should be the one provided in mocha.opts.
  * If omitted the default one is "mochawesome-report".
- * This is necessary because we need the logged images to be relatively 
+ * This is necessary because we need the logged images to be relatively
  * positioned according to mochawesome.html in the same folder
  */
 testReporterContext.reportDir = "mochawesome-report";

seed-tests/e2e/tests.e2e.ts

@@ -1,19 +1,18 @@
-import { AppiumDriver, createDriver, SearchOptions, Direction, nsCapabilities } from "nativescript-dev-appium";
-import { isSauceLab, runType } from "nativescript-dev-appium/lib/parser";
+import { AppiumDriver, createDriver, SearchOptions, nsCapabilities } from "nativescript-dev-appium";
+import { isSauceLab } from "nativescript-dev-appium/lib/parser";
 import { expect } from "chai";
 import "mocha";
-import { ok } from "assert";
+
 const fs = require('fs');
 const addContext = require('mochawesome/addContext');
 const rimraf = require('rimraf');
 const isSauceRun = isSauceLab;
 
-
 describe("sample scenario", () => {
     let driver: AppiumDriver;
 
-    before(async function(){
-        nsCapabilities.testReporter.context = this; 
+    before(async function() {
+        nsCapabilities.testReporter.context = this;
         driver = await createDriver();
         driver.defaultWaitTime = 20000;
         let dir = "mochawesome-report";

seed-tests/postclone.tests.js

@@ -187,12 +187,17 @@ describe('postclone', function () {
         expect(fs.existsSync(constants.SEED_COPY_LOCATION + "/seed-tests")).toBeFalsy();
     });
 
-    it('should replace the seed README with the plugin one', function () {
+    it('should rename each yourplugin file with the new plugin name in README', function () {
         expect(fs.existsSync(constants.SEED_COPY_LOCATION + "/README.md")).toBeTruthy();
-        expect(fs.existsSync(constants.SEED_COPY_LOCATION + "/src/README.md")).toBeFalsy();
 
         var readmeContent = fs.readFileSync(constants.SEED_COPY_LOCATION + "/README.md");
-        expect(_srcReadmeContent).toEqual(readmeContent);
+        expect(readmeContent).toContain("nativescript-" + constants.TEST_PLUGIN_NAME);
+        expect(readmeContent).toContain("tns plugin add nativescript-" + constants.TEST_PLUGIN_NAME);
+    });
+
+    it('should remove old src/README and create a new /README', function() {
+        expect(fs.existsSync(constants.SEED_COPY_LOCATION + "/README.md")).toBeTruthy();
+        expect(fs.existsSync(constants.SEED_COPY_LOCATION + "/src/README.md")).toBeFalsy();
     });
 
     it('should rename each yourplugin file', function (done) {

src/README.md

@@ -1,4 +1,4 @@
-# Your Plugin Name
+# nativescript-yourplugin
 
 Add your plugin badges here. See [nativescript-urlhandler](https://github.com/hypery2k/nativescript-urlhandler) for example.
 
@@ -15,7 +15,7 @@ Describe the prerequisites that the user need to have installed before using you
 Describe your plugin installation steps. Ideally it would be something like:
 
 ```javascript
-tns plugin add <your-plugin-name>
+tns plugin add nativescript-yourplugin
 ```
 
 ## Usage