Merge pull request #124 from NativeScript/feature/nested-properties

Allow settingnested properties

Author: vakrilov

ng-sample/.vscode/settings.json

@@ -5,7 +5,6 @@
       "when": "$(basename).ts"
     },
     "**/*.js.map": {},
-    "platforms/**": {},
-    "hooks/**": {}
+    "platforms/**": {}
   }
 }

ng-sample/app/examples/action-bar/action-bar-test.ts

@@ -10,6 +10,7 @@ import {NS_DIRECTIVES} from "../../nativescript-angular/directives/ns-directives
     template: `    
     <ActionBar title="Custom Title"> 
         <ActionItem *ngIf="show" text="action" (tap)="onTap()"></ActionItem>
+        <ActionItem ios.systemIcon="9" android.systemIcon="ic_menu_share_holo_light" (tap)="onShare()"></ActionItem>
     </ActionBar>
 
     <StackLayout verticalAlignment="center">
@@ -23,6 +24,9 @@ class FirstComponent {
     onTap() {
         console.log("FirstComponent.Tapped!");
     }
+    onShare() {
+        console.log("Share button tapped!");
+    }
 }
 
 

src/nativescript-angular/view-util.ts

@@ -1,4 +1,4 @@
-import {isString} from "utils/types";
+import {isString, isDefined} from "utils/types";
 import {View} from "ui/core/view";
 import {Placeholder} from "ui/placeholder";
 import {ContentView} from 'ui/content-view';
@@ -139,6 +139,31 @@ function isXMLAttribute(name: string): boolean {
 }
 
 export function setProperty(view: NgView, attributeName: string, value: any): void {
+    if (attributeName.indexOf(".") !== -1) {
+        // Handle nested properties
+        const properties = attributeName.split(".");
+        attributeName = properties[properties.length - 1];
+
+        let propMap = getProperties(view);
+        let i = 0;
+        while (i < properties.length - 1 && isDefined(view)) {
+            var prop = properties[i];
+            if (propMap.has(prop)) {
+                prop = propMap.get(prop);
+            }
+
+            view = view[prop];
+            propMap = getProperties(view);
+            i++;
+        }
+    }
+
+    if (isDefined(view)) {
+        setPropertyInternal(view, attributeName, value);
+    }
+}
+
+function setPropertyInternal(view: NgView, attributeName: string, value: any): void {
     traceLog('Setting attribute: ' + attributeName);
 
     let specialSetter = getSpecialPropertySetter(attributeName);
@@ -161,7 +186,7 @@ export function setProperty(view: NgView, attributeName: string, value: any): vo
 }
 
 function convertValue(value: any): any {
-    if (typeof(value) !== "string" || value === "") {
+    if (typeof (value) !== "string" || value === "") {
         return value;
     }
 

tests/app/tests/property-sets.ts

@@ -17,6 +17,7 @@ class TestView extends View implements ViewExtensions {
     public numValue: number = 0;
     public boolValue: boolean = undefined;
     public anyValue: any = undefined;
+    public nested: { property: string } = { property: "untouched" };
 }
 
 describe('setting View properties', () => {
@@ -63,9 +64,16 @@ describe('setting View properties', () => {
     });
 
     it('preserves objects', () => {
-        let value = {name: "Jim", age: 23};
+        let value = { name: "Jim", age: 23 };
         let view = new TestView();
         setProperty(view, "anyValue", value)
         assert.deepEqual(value, view.anyValue);
     });
+
+    it('sets nested properties', () => {
+        let view = new TestView();
+        setProperty(view, "nested.property", "blah")
+        assert.strictEqual("blah", view.nested.property);
+    });
+   
 });