Skip to content

Commit 50745b9

Browse files
committed
v8: fix v8 build failing due to incorrect args
1 parent 464a8a4 commit 50745b9

File tree

1 file changed

+8
-1
lines changed

1 file changed

+8
-1
lines changed

test-app/runtime/CMakeLists.txt

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,15 @@ if (CCACHE_FOUND AND (USE_CCACHE))
1818
set_property(GLOBAL PROPERTY RULE_LAUNCH_LINK ccache)
1919
endif (CCACHE_FOUND AND (USE_CCACHE))
2020

21-
set(COMMON_CMAKE_ARGUMENTS "-std=c++17 -Wno-error -Wno-deprecated-declarations -Wno-unused-result -mstackrealign -fexceptions -fno-builtin-stpcpy -frtti")
21+
set(COMMON_CMAKE_ARGUMENTS "-std=c++17 -Wno-error -Wno-deprecated-declarations -Wno-unused-result -mstackrealign -fexceptions -fno-builtin-stpcpy")
2222
set(MI_OVERRIDE OFF)
23+
24+
if (SHERMES)
25+
set(COMMON_CMAKE_ARGUMENTS "${COMMON_CMAKE_ARGUMENTS} -frtti")
26+
else
27+
set(COMMON_CMAKE_ARGUMENTS "${COMMON_CMAKE_ARGUMENTS} -fno-rtti")
28+
endif
29+
2330
# AOSP has switched to using LLD by default and the NDK will use it by default in the next release.
2431
# BFD and Gold will be removed once LLD has been through a release cycle with no major unresolved issues (estimated r21)
2532
# Note: lld does not currently work on Windows: https://github.com/android-ndk/ndk/issues/888

0 commit comments

Comments
 (0)