Repository navigation
Commit 3645898
committed
fix(napi): enter the env's context around async-work completion
CompleteAsyncWork called into the module with only the loop entry's
Locker + Isolate::Scope + HandleScope, leaving the current context
empty — addon complete callbacks (and the exception reporter on the
napi_throw_error failure path) observed no entered context. Open a
HandleScope + Context::Scope first, mirroring NapiEnv::CallFinalizer
and the TSFN dispatch path. Same fix as NativeScript/android#2004.
Fixes #4411 parent 9fb910c commit 3645898
1 file changed
Lines changed: 4 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
525 | 525 | | |
526 | 526 | | |
527 | 527 | | |
| 528 | + | |
| 529 | + | |
| 530 | + | |
| 531 | + | |
528 | 532 | | |
529 | 533 | | |
530 | 534 | | |
| |||
0 commit comments