Skip to content

Ensure php-bin is removed from built app #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

PeteBishwhip
Copy link
Member

Fixes NativePHP/laravel#503

  • Ensure php-bin is removed after composer has run
  • Resolves notarisation issues with apple
  • Reduces app size

Fixes NativePHP/laravel#503

- Ensure php-bin is removed after composer has run
- Resolves notarisation issues with apple
- Reduces app size
@PeteBishwhip PeteBishwhip self-assigned this Feb 27, 2025
@PeteBishwhip PeteBishwhip requested a review from a team February 27, 2025 14:36
@PeteBishwhip PeteBishwhip requested a review from a team February 27, 2025 14:40
@gwleuverink
Copy link
Contributor

We must ship!

@PeteBishwhip PeteBishwhip requested review from simonhamp and a team February 27, 2025 16:43
@simonhamp simonhamp merged commit 1d237a1 into main Feb 27, 2025
77 of 78 checks passed
@PeteBishwhip PeteBishwhip deleted the bugfix/503-ensure-vendor-cleanup-occurs branch February 28, 2025 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Vendor directory cleanup failing - Causing build notary failures
3 participants