Skip to content

Commit 1f81206

Browse files
committed
Refactored code
1 parent 91a1f0e commit 1f81206

File tree

6 files changed

+16
-16
lines changed

6 files changed

+16
-16
lines changed

src/main/java/DoubleOfEvenNumberAfter3.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@ private static Integer computeImperative(List<Integer> numbers) {
77
Integer result = null;
88

99
for(int e : numbers) {
10-
if(UtilityMethods.findNumberGreaterThan3(e) && UtilityMethods.findEvenNumber(e)) {
11-
result = UtilityMethods.doubleTheValue(e);
10+
if(Utility.findNumberGreaterThan3(e) && Utility.findEvenNumber(e)) {
11+
result = Utility.doubleTheValue(e);
1212
break;
1313
}
1414
}

src/main/scala/PlayingWithNumbers.scala

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@ object PlayingWithNumbers extends App {
1212
var result = 0
1313
breakable {
1414
for(num <- numbers){
15-
if (UtilityMethods.findNumberGreaterThan3(num) && UtilityMethods.findEvenNumber(num)) {
16-
result = num * 2
15+
if (Utility.findNumberGreaterThan3(num) && Utility.findEvenNumber(num)) {
16+
result = Utility.doubleTheValue(num)
1717
break
1818
}
1919
}

src/main/scala/PlayingWithNumbersFunctionally.scala

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,9 @@ object PlayingWithNumbersFunctionally extends App {
1010

1111
def computeFunctionally(numbers: List[Int]): Int = {
1212
numbers
13-
.filter(UtilityMethods.findNumberGreaterThan3)
14-
.filter(UtilityMethods.findEvenNumber)
15-
.map(UtilityMethods.doubleTheValue)
13+
.filter(Utility.findNumberGreaterThan3)
14+
.filter(Utility.findEvenNumber)
15+
.map(Utility.doubleTheValue)
1616
.head
1717
}
1818

src/main/scala/PlayingWithNumbersLazily.scala

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,9 @@ object PlayingWithNumbersLazily extends App {
1010
def computeUsingLazyEvaluation(numbers: List[Int]): Int = {
1111
numbers
1212
.toStream
13-
.filter(UtilityMethods.findNumberGreaterThan3)
14-
.filter(UtilityMethods.findEvenNumber)
15-
.map(UtilityMethods.doubleTheValue)
13+
.filter(Utility.findNumberGreaterThan3)
14+
.filter(Utility.findEvenNumber)
15+
.map(Utility.doubleTheValue)
1616
.head
1717
}
1818

src/main/scala/Prices.scala

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@ object Prices extends App{
1717
println(s"total of discounted prices $totalDiscountPrices")
1818

1919
val totalDiscountPricesUsingFP = prices
20-
.filter(_ > 20)
21-
.map(_ * 0.9)
20+
.filter(e => e > 20)
21+
.map(e => e * 0.9)
2222
.sum
2323

2424
println(s"total of discounted prices using Functional Composition " +

src/main/scala/UtilityMethods.scala renamed to src/main/scala/Utility.scala

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,20 +2,20 @@
22
/**
33
* Commonly used methods
44
*/
5-
object UtilityMethods {
5+
object Utility {
66

77
def findNumberGreaterThan3(number: Int): Boolean = {
8-
println("Inside findNumberGreaterThan3")
8+
println(s"Inside findNumberGreaterThan3 with number $number")
99
number > 3
1010
}
1111

1212
def findEvenNumber(number: Int): Boolean = {
13-
println("Inside findEvenNumber")
13+
println(s"Inside findEvenNumber with number $number")
1414
number % 2 == 0
1515
}
1616

1717
def doubleTheValue(number: Int): Int = {
18-
println("Inside doubleTheValue")
18+
println(s"Inside doubleTheValue with number $number")
1919
number * 2
2020
}
2121
}

0 commit comments

Comments
 (0)