Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work with Vapor? #52

Open
msnegurski opened this issue Apr 21, 2024 · 5 comments
Open

Doesn't work with Vapor? #52

msnegurski opened this issue Apr 21, 2024 · 5 comments

Comments

@msnegurski
Copy link

Hey, curious if anyone encountered this issue. It just straight up doesn't work with Vapor. From doing some digging issue seems to be that HTTP_X_AMZN_TRACE_ID and LAMBDA_INVOCATION_CONTEXT variable are not present in either $_SERVER or $_ENV.

@msnegurski
Copy link
Author

Xray is enabled and configured and general traces are present. But anything that happens inside Laravel app is absent. Here is a screenshot as example.

CleanShot 2024-04-21 at 11 49 52@2x

@emaadali
Copy link
Contributor

emaadali commented May 2, 2024

@msnegurski Were you able to figure this out?

@msnegurski
Copy link
Author

@emaadali unfortunately not, basically gave up on this idea

I made some custom trace id generation and got it working somewhat, however that means traces from Laravel will not be linked to traces automatically generated by Lambda (from screenshot)

@yani-
Copy link

yani- commented Jul 22, 2024

Yes, it supports vapor out of the box. You have to configure the submitter in config/xray.php to:

    'submitter' => \Napp\Xray\Submission\DaemonSegmentSubmitter::class,

@phadaphunk
Copy link

Anyone made it work? Or is this dead. I can only see lambda invocations and http response codes but nothing else is being logged even though I followed the doc for vapor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants