Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change batch dimension to channel dimension #7

Merged
merged 1 commit into from
Aug 3, 2020

Conversation

rajatsaini0294
Copy link
Collaborator

@rajatsaini0294 rajatsaini0294 commented Aug 2, 2020

The PR proposes to change the batch dimension to channel dimension.
There is no difference in the results reported as the code was rewritten for the optimization. This bug is not present in the experiment environment.

@rajatsaini0294 rajatsaini0294 requested a review from Nandan91 August 2, 2020 08:15
Copy link
Owner

@Nandan91 Nandan91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rajatsaini0294 rajatsaini0294 merged commit 7f10160 into master Aug 3, 2020
@rajatsaini0294 rajatsaini0294 deleted the bugfix/change_dimension branch August 3, 2020 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants