Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/add grouped attention block #3

Merged
merged 3 commits into from
Jul 23, 2020
Merged

Feature/add grouped attention block #3

merged 3 commits into from
Jul 23, 2020

Conversation

rajatsaini0294
Copy link
Collaborator

This PR proposes to add Grouped Attention Block.

@rajatsaini0294 rajatsaini0294 requested a review from Nandan91 July 22, 2020 12:44
@Nandan91
Copy link
Owner

Seems fine

Nandan91
Nandan91 approved these changes Jul 23, 2020
View reviewed changes
Copy link
Owner

@Nandan91 Nandan91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine!

@Nandan91 Nandan91 merged commit 1bbcda6 into master Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nandan91 Nandan91 Nandan91 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rajatsaini0294 @Nandan91