Rewrite C ext to public C api #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BDIGIT api is internal ruby C api, and was removed from public api after
merge of Bignum and Fixnum into Integer.
Now use public C ruby api.
It is slower than previous BDIGIT api, but much faster than ruby version
user system total real
distance3_bdigit 0.198673 0.000000 0.198673 (0.198672)
distance3_public 0.373779 0.000000 0.373779 (0.373777)
distance3_ruby 1.824285 0.000000 1.824285 (1.824315)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BDIGIT api is an internal ruby C api, and was removed from public api after merge of Bignum and Fixnum into Integer.
Using public API's rb_integer_pack which converts a ruby integer to array of C integers(or longs).
It is slower than the previous BDIGIT api, but much faster than ruby version
Tested on
cc #21