Include all files in the bundle, not just PNGs, in Cocoapods resource bundle #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… bundle This change has no functional effect at this time. However, now that we have a proper bundle in the repo, it seems proper to direct CocoaPods to package _all_ files in that bundle into its (equivalent) resource bundle. This eliminates room for future error: if a non-PNG file is added to the bundle, before this change, it would appear to work with Carthage but not with CocoaPods.
cdzombak
changed the title
Twigz
added a commit
that referenced
this pull request
Mar 11, 2016
…oapods-bundle Include all files in the bundle, not just PNGs, in Cocoapods resource bundle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change has no functional effect at this time. However, now that we have a proper bundle in the repo, it seems proper to direct CocoaPods to package all files in that bundle into its (equivalent) resource bundle.
This eliminates room for future error: if a non-PNG file is added to the bundle, before this change, it would appear to work with Carthage but not with CocoaPods.