Fix orientation issue with reference view of type UIImageView #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue occurred during in and out animations when the reference view is a UIImageView containing a UIImage with meaningful orientation informations (e.g. taken directly with the device in portrait orientation).
|
I can confirm that this issue is happening on photos taken in portrait orientation, at least on iPhone 6 and iPhone 6s. Fix in PR fixes the issue. |
|
@lrossi This looks good to merge. I'll fix the use of tabs, and add a link to the issue as a comment in a separate PR. Thanks! |
dzlobin
added a commit
that referenced
this pull request
Jan 26, 2016
Fix orientation issue with reference view of type UIImageView
|
@dzlobin Thanks and sorry for the tabs ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue occurred during in and out animations when the reference
view is a UIImageView containing a UIImage with meaningful
orientation informations (e.g. taken directly with the device in
portrait orientation). See #115.