Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Events claimed by a render pass are still propagated further down #257

Open
pierremoreau opened this issue Sep 19, 2020 · 0 comments
Open

Comments

@pierremoreau
Copy link
Contributor

This is an issue, for example, when using the SplitScreenPass as moving the divider between the two splits results in the camera moving along.

SplitScreenPass::onMouseEvent() returns true when the divider is grabbed, as expected, but Mogwai's Renderer::onMouseEvent() does not check the return value of the RenderGraph::onMouseEvent() method and so will still call the onMouseEvent() method on the scene (therefore resulting in the camera moving along despite the SplitScreenPass pass claiming the events).

The same issue applies to keyboard events.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant