Skip to content

Commit 4deb843

Browse files
authored
Updating public-API to use the lib with a single import (#205)
1 parent 2b202fc commit 4deb843

37 files changed

+402
-392
lines changed

tests/tf/block/test_base.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,24 +16,24 @@
1616

1717
import pytest
1818

19-
tf4rec = pytest.importorskip("transformers4rec.tf")
19+
tr = pytest.importorskip("transformers4rec.tf")
2020

2121

2222
def test_sequential_block_yoochoose(yoochoose_schema, tf_yoochoose_like):
23-
inputs = tf4rec.TabularFeatures.from_schema(yoochoose_schema, aggregation="concat")
23+
inputs = tr.TabularFeatures.from_schema(yoochoose_schema, aggregation="concat")
2424

25-
body = tf4rec.SequentialBlock([inputs, tf4rec.MLPBlock([64])])
25+
body = tr.SequentialBlock([inputs, tr.MLPBlock([64])])
2626

2727
outputs = body(tf_yoochoose_like)
2828

2929
assert list(outputs.shape) == [100, 64]
3030

3131

3232
def test_sequential_block_yoochoose_without_aggregation(yoochoose_schema, tf_yoochoose_like):
33-
inputs = tf4rec.TabularFeatures.from_schema(yoochoose_schema)
33+
inputs = tr.TabularFeatures.from_schema(yoochoose_schema)
3434

3535
with pytest.raises(TypeError) as excinfo:
36-
body = tf4rec.SequentialBlock([inputs, tf4rec.MLPBlock([64])])
36+
body = tr.SequentialBlock([inputs, tr.MLPBlock([64])])
3737

3838
body(tf_yoochoose_like)
3939

tests/tf/block/test_dlrm.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,13 +16,13 @@
1616

1717
import pytest
1818

19-
tf4rec = pytest.importorskip("transformers4rec.tf")
19+
tr = pytest.importorskip("transformers4rec.tf")
2020

2121

2222
def test_dlrm_block_yoochoose(yoochoose_schema, tf_yoochoose_like):
23-
dlrm = tf4rec.DLRMBlock.from_schema(yoochoose_schema, bottom_mlp=tf4rec.MLPBlock([64]))
23+
dlrm = tr.DLRMBlock.from_schema(yoochoose_schema, bottom_mlp=tr.MLPBlock([64]))
2424

25-
body = tf4rec.SequentialBlock([dlrm, tf4rec.MLPBlock([64])])
25+
body = tr.SequentialBlock([dlrm, tr.MLPBlock([64])])
2626

2727
outputs = body(tf_yoochoose_like)
2828

tests/tf/block/test_mlp.py

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@
1616

1717
import pytest
1818

19-
tf4rec = pytest.importorskip("transformers4rec.tf")
2019
tf = pytest.importorskip("tensorflow")
20+
tr = pytest.importorskip("transformers4rec.tf")
2121

2222

2323
@pytest.mark.parametrize("dim", [32, 64])
@@ -29,12 +29,10 @@
2929
def test_mlp_block_yoochoose(
3030
yoochoose_schema, tf_yoochoose_like, dim, activation, dropout, normalization
3131
):
32-
inputs = tf4rec.TabularFeatures.from_schema(yoochoose_schema, aggregation="concat")
32+
inputs = tr.TabularFeatures.from_schema(yoochoose_schema, aggregation="concat")
3333

34-
mlp = tf4rec.MLPBlock(
35-
[dim], activation=activation, dropout=dropout, normalization=normalization
36-
)
37-
body = tf4rec.SequentialBlock([inputs, mlp])
34+
mlp = tr.MLPBlock([dim], activation=activation, dropout=dropout, normalization=normalization)
35+
body = tr.SequentialBlock([inputs, mlp])
3836

3937
outputs = body(tf_yoochoose_like)
4038

tests/tf/block/test_transformer.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818

1919
from transformers4rec.config import transformer as tconf
2020

21-
tf4rec = pytest.importorskip("transformers4rec.tf")
21+
tr = pytest.importorskip("transformers4rec.tf")
2222

2323
config_classes = [
2424
tconf.XLNetConfig,
@@ -27,7 +27,7 @@
2727
]
2828

2929
# fixed parameters for tests
30-
lm_tasks = list(tf4rec.masking.masking_registry.keys())
30+
lm_tasks = list(tr.masking.masking_registry.keys())
3131
# lm_tasks.remove("permutation")
3232

3333

@@ -36,7 +36,7 @@
3636
def test_transformer_block(yoochoose_schema, tf_yoochoose_like, task):
3737

3838
col_group = yoochoose_schema
39-
tab_module = tf4rec.TabularSequenceFeatures.from_schema(
39+
tab_module = tr.TabularSequenceFeatures.from_schema(
4040
col_group,
4141
max_sequence_length=20,
4242
aggregation="sequential-concat",
@@ -47,11 +47,11 @@ def test_transformer_block(yoochoose_schema, tf_yoochoose_like, task):
4747
d_model=64, n_head=4, n_layer=2, total_seq_length=20
4848
)
4949

50-
block = tf4rec.SequentialBlock(
50+
block = tr.SequentialBlock(
5151
[
5252
tab_module,
53-
tf4rec.MLPBlock([64]),
54-
tf4rec.TransformerBlock(transformer_config, masking=tab_module.masking),
53+
tr.MLPBlock([64]),
54+
tr.TransformerBlock(transformer_config, masking=tab_module.masking),
5555
]
5656
)
5757

tests/tf/conftest.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
from merlin_standard_lib.utils.proto_utils import has_field, proto_text_to_better_proto
2626

2727
tf = pytest.importorskip("tensorflow")
28-
tf4rec = pytest.importorskip("transformers4rec.tf")
28+
tr = pytest.importorskip("transformers4rec.tf")
2929

3030
NUM_EXAMPLES = 1000
3131
MAX_CARDINALITY = 100
@@ -56,7 +56,7 @@ def tf_cat_features():
5656

5757
@pytest.fixture
5858
def tf_yoochoose_tabular_features(yoochoose_schema):
59-
return tf4rec.TabularFeatures.from_schema(
59+
return tr.TabularFeatures.from_schema(
6060
yoochoose_schema,
6161
max_sequence_length=20,
6262
continuous_projection=64,
@@ -66,7 +66,7 @@ def tf_yoochoose_tabular_features(yoochoose_schema):
6666

6767
@pytest.fixture
6868
def tf_yoochoose_tabular_sequence_features(yoochoose_schema):
69-
return tf4rec.TabularSequenceFeatures.from_schema(
69+
return tr.TabularSequenceFeatures.from_schema(
7070
yoochoose_schema,
7171
max_sequence_length=20,
7272
continuous_projection=64,

tests/tf/features/test_continuous.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -17,29 +17,29 @@
1717
import pytest
1818

1919
from merlin_standard_lib import Tag
20-
from tests.tf import _utils as test_utils
2120

22-
tf4rec = pytest.importorskip("transformers4rec.tf")
21+
tr = pytest.importorskip("transformers4rec.tf")
22+
test_utils = pytest.importorskip("transformers4rec.tf.utils.testing_utils")
2323

2424

2525
def test_continuous_features(tf_con_features):
2626
features = ["a", "b"]
27-
con = tf4rec.ContinuousFeatures(features)(tf_con_features)
27+
con = tr.ContinuousFeatures(features)(tf_con_features)
2828

2929
assert list(con.keys()) == features
3030

3131

3232
def test_continuous_features_yoochoose(yoochoose_schema, tf_yoochoose_like):
3333
schema = yoochoose_schema.select_by_tag(Tag.CONTINUOUS)
3434

35-
inputs = tf4rec.ContinuousFeatures.from_schema(schema)
35+
inputs = tr.ContinuousFeatures.from_schema(schema)
3636
outputs = inputs(tf_yoochoose_like)
3737

3838
assert list(outputs.keys()) == schema.column_names
3939

4040

4141
def test_serialization_continuous_features(yoochoose_schema, tf_yoochoose_like):
42-
inputs = tf4rec.ContinuousFeatures.from_schema(yoochoose_schema)
42+
inputs = tr.ContinuousFeatures.from_schema(yoochoose_schema)
4343

4444
copy_layer = test_utils.assert_serialization(inputs)
4545

@@ -50,7 +50,7 @@ def test_serialization_continuous_features(yoochoose_schema, tf_yoochoose_like):
5050
def test_continuous_features_yoochoose_model(yoochoose_schema, tf_yoochoose_like, run_eagerly):
5151
schema = yoochoose_schema.select_by_tag(Tag.CONTINUOUS)
5252

53-
inputs = tf4rec.ContinuousFeatures.from_schema(schema, aggregation="concat")
54-
body = tf4rec.SequentialBlock([inputs, tf4rec.MLPBlock([64])])
53+
inputs = tr.ContinuousFeatures.from_schema(schema, aggregation="concat")
54+
body = tr.SequentialBlock([inputs, tr.MLPBlock([64])])
5555

5656
test_utils.assert_body_works_in_model(tf_yoochoose_like, inputs, body, run_eagerly)

tests/tf/features/test_embedding.py

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -18,18 +18,18 @@
1818
from tensorflow.python.ops import init_ops_v2
1919

2020
from merlin_standard_lib import Tag
21-
from tests.tf import _utils as test_utils
2221

23-
tf4rec = pytest.importorskip("transformers4rec.tf")
22+
tr = pytest.importorskip("transformers4rec.tf")
23+
test_utils = pytest.importorskip("transformers4rec.tf.utils.testing_utils")
2424

2525

2626
def test_embedding_features(tf_cat_features):
2727
dim = 15
2828
feature_config = {
29-
f: tf4rec.FeatureConfig(tf4rec.TableConfig(100, dim, name=f, initializer=None))
29+
f: tr.FeatureConfig(tr.TableConfig(100, dim, name=f, initializer=None))
3030
for f in tf_cat_features.keys()
3131
}
32-
embeddings = tf4rec.EmbeddingFeatures(feature_config)(tf_cat_features)
32+
embeddings = tr.EmbeddingFeatures(feature_config)(tf_cat_features)
3333

3434
assert list(embeddings.keys()) == list(feature_config.keys())
3535
assert all([emb.shape[-1] == dim for emb in embeddings.values()])
@@ -38,7 +38,7 @@ def test_embedding_features(tf_cat_features):
3838
def test_embedding_features_yoochoose(yoochoose_schema, tf_yoochoose_like):
3939
schema = yoochoose_schema.select_by_tag(Tag.CATEGORICAL)
4040

41-
emb_module = tf4rec.EmbeddingFeatures.from_schema(schema)
41+
emb_module = tr.EmbeddingFeatures.from_schema(schema)
4242
embeddings = emb_module(tf_yoochoose_like)
4343

4444
assert list(embeddings.keys()) == schema.column_names
@@ -48,7 +48,7 @@ def test_embedding_features_yoochoose(yoochoose_schema, tf_yoochoose_like):
4848

4949

5050
def test_serialization_embedding_features(yoochoose_schema, tf_yoochoose_like):
51-
inputs = tf4rec.EmbeddingFeatures.from_schema(yoochoose_schema)
51+
inputs = tr.EmbeddingFeatures.from_schema(yoochoose_schema)
5252

5353
copy_layer = test_utils.assert_serialization(inputs)
5454

@@ -66,16 +66,16 @@ def test_serialization_embedding_features(yoochoose_schema, tf_yoochoose_like):
6666
def test_embedding_features_yoochoose_model(yoochoose_schema, tf_yoochoose_like, run_eagerly):
6767
schema = yoochoose_schema.select_by_tag(Tag.CATEGORICAL)
6868

69-
inputs = tf4rec.EmbeddingFeatures.from_schema(schema, aggregation="concat")
70-
body = tf4rec.SequentialBlock([inputs, tf4rec.MLPBlock([64])])
69+
inputs = tr.EmbeddingFeatures.from_schema(schema, aggregation="concat")
70+
body = tr.SequentialBlock([inputs, tr.MLPBlock([64])])
7171

7272
test_utils.assert_body_works_in_model(tf_yoochoose_like, inputs, body, run_eagerly)
7373

7474

7575
def test_embedding_features_yoochoose_custom_dims(yoochoose_schema, tf_yoochoose_like):
7676
schema = yoochoose_schema.select_by_tag(Tag.CATEGORICAL)
7777

78-
emb_module = tf4rec.EmbeddingFeatures.from_schema(
78+
emb_module = tr.EmbeddingFeatures.from_schema(
7979
schema, embedding_dims={"item_id/list": 100}, embedding_dim_default=64
8080
)
8181

@@ -91,7 +91,7 @@ def test_embedding_features_yoochoose_custom_dims(yoochoose_schema, tf_yoochoose
9191
def test_embedding_features_yoochoose_infer_embedding_sizes(yoochoose_schema, tf_yoochoose_like):
9292
schema = yoochoose_schema.select_by_tag(Tag.CATEGORICAL)
9393

94-
emb_module = tf4rec.EmbeddingFeatures.from_schema(
94+
emb_module = tr.EmbeddingFeatures.from_schema(
9595
schema, infer_embedding_sizes=True, infer_embedding_sizes_multiplier=3.0
9696
)
9797

@@ -112,7 +112,7 @@ def test_embedding_features_yoochoose_custom_initializers(yoochoose_schema, tf_y
112112
CATEGORY_STD = 0.1
113113

114114
schema = yoochoose_schema.select_by_tag(Tag.CATEGORICAL)
115-
emb_module = tf4rec.EmbeddingFeatures.from_schema(
115+
emb_module = tr.EmbeddingFeatures.from_schema(
116116
schema,
117117
embeddings_initializers={
118118
"item_id/list": init_ops_v2.TruncatedNormal(mean=ITEM_MEAN, stddev=ITEM_STD),

tests/tf/features/test_sequence.py

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -17,14 +17,14 @@
1717
import pytest
1818

1919
from merlin_standard_lib import Tag
20-
from tests.tf import _utils as test_utils
2120

22-
tf4rec = pytest.importorskip("transformers4rec.tf")
21+
tr = pytest.importorskip("transformers4rec.tf")
22+
test_utils = pytest.importorskip("transformers4rec.tf.utils.testing_utils")
2323

2424

2525
def test_sequence_embedding_features(yoochoose_schema, tf_yoochoose_like):
2626
schema = yoochoose_schema.select_by_tag(Tag.CATEGORICAL)
27-
emb_module = tf4rec.SequenceEmbeddingFeatures.from_schema(schema)
27+
emb_module = tr.SequenceEmbeddingFeatures.from_schema(schema)
2828

2929
outputs = emb_module(tf_yoochoose_like)
3030

@@ -35,7 +35,7 @@ def test_sequence_embedding_features(yoochoose_schema, tf_yoochoose_like):
3535

3636

3737
def test_serialization_sequence_embedding_features(yoochoose_schema, tf_yoochoose_like):
38-
inputs = tf4rec.SequenceEmbeddingFeatures.from_schema(yoochoose_schema)
38+
inputs = tr.SequenceEmbeddingFeatures.from_schema(yoochoose_schema)
3939

4040
copy_layer = test_utils.assert_serialization(inputs)
4141

@@ -53,17 +53,17 @@ def test_serialization_sequence_embedding_features(yoochoose_schema, tf_yoochoos
5353
def test_sequence_embedding_features_yoochoose_model(
5454
yoochoose_schema, tf_yoochoose_like, run_eagerly
5555
):
56-
inputs = tf4rec.TabularSequenceFeatures.from_schema(
56+
inputs = tr.TabularSequenceFeatures.from_schema(
5757
yoochoose_schema, max_sequence_length=20, aggregation="sequential-concat"
5858
)
5959

60-
body = tf4rec.SequentialBlock([inputs, tf4rec.MLPBlock([64])])
60+
body = tr.SequentialBlock([inputs, tr.MLPBlock([64])])
6161

6262
test_utils.assert_body_works_in_model(tf_yoochoose_like, inputs, body, run_eagerly)
6363

6464

6565
def test_sequence_tabular_features_with_projection(yoochoose_schema, tf_yoochoose_like):
66-
tab_module = tf4rec.TabularSequenceFeatures.from_schema(
66+
tab_module = tr.TabularSequenceFeatures.from_schema(
6767
yoochoose_schema, max_sequence_length=20, continuous_projection=64
6868
)
6969

@@ -75,7 +75,7 @@ def test_sequence_tabular_features_with_projection(yoochoose_schema, tf_yoochoos
7575

7676

7777
def test_serialization_sequence_tabular_features(yoochoose_schema, tf_yoochoose_like):
78-
inputs = tf4rec.TabularSequenceFeatures.from_schema(yoochoose_schema)
78+
inputs = tr.TabularSequenceFeatures.from_schema(yoochoose_schema)
7979

8080
copy_layer = test_utils.assert_serialization(inputs)
8181

@@ -88,12 +88,12 @@ def test_tabular_features_yoochoose_direct(
8888
tf_yoochoose_like,
8989
run_eagerly,
9090
):
91-
continuous_layer = tf4rec.ContinuousFeatures.from_schema(yoochoose_schema, tags=["continuous"])
92-
categorical_layer = tf4rec.SequenceEmbeddingFeatures.from_schema(
91+
continuous_layer = tr.ContinuousFeatures.from_schema(yoochoose_schema, tags=["continuous"])
92+
categorical_layer = tr.SequenceEmbeddingFeatures.from_schema(
9393
yoochoose_schema, tags=["categorical"]
9494
)
9595

96-
inputs = tf4rec.TabularSequenceFeatures(
96+
inputs = tr.TabularSequenceFeatures(
9797
continuous_layer=continuous_layer,
9898
categorical_layer=categorical_layer,
9999
aggregation="sequential-concat",
@@ -141,12 +141,12 @@ def test_tabular_features_yoochoose_direct(
141141

142142
def test_sequence_tabular_features_with_projection_and_d_output(yoochoose_schema):
143143
with pytest.raises(ValueError) as excinfo:
144-
tf4rec.TabularSequenceFeatures.from_schema(
144+
tr.TabularSequenceFeatures.from_schema(
145145
yoochoose_schema,
146146
max_sequence_length=20,
147147
continuous_projection=64,
148148
d_output=100,
149-
projection=tf4rec.MLPBlock([64]),
149+
projection=tr.MLPBlock([64]),
150150
masking="causal",
151151
)
152152

0 commit comments

Comments
 (0)