Validate the output of all reader masks #802
Labels
bug
Something isn't working
discussion required
This issue requires discussion before implementation
potential bug
Functionality that is working but maybe not as expected. Need to investigate further.
testing
Test datasets, scripts, and processes
Milestone
Requested Update
Description
This issue requests that we should go through all of the reader plugins and verify that the masking that they implement works as expected and produces valid output. If possible, it'd also be nice to generalize common data manipulations used by readers so that we could ensure the code is working in just one location.
Background and Motivation
This stems from testing @jsolbrig and I performed on PR #427. When checking the output of
B03Rad
, we noticed that values of-999.8
still existed when reading fromabi_netcdf
. Further testing showed that allRad
channels had the same issue.Ref
channels were fine, which makes this a bit confusing. Masking performed in that PR should be applied to all values less than or equal to-999.0
, which didn't seem to occur here.Code to demonstrate issue
geoips.plugins.modules.readers.abi_netcdf:get_data:1079
in PR #427.Checklist for Completion
The text was updated successfully, but these errors were encountered: