Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate the output of all reader masks #802

Open
3 tasks
evrose54 opened this issue Oct 23, 2024 · 0 comments
Open
3 tasks

Validate the output of all reader masks #802

evrose54 opened this issue Oct 23, 2024 · 0 comments
Labels
bug Something isn't working discussion required This issue requires discussion before implementation potential bug Functionality that is working but maybe not as expected. Need to investigate further. testing Test datasets, scripts, and processes
Milestone

Comments

@evrose54
Copy link
Contributor

Requested Update

Description

This issue requests that we should go through all of the reader plugins and verify that the masking that they implement works as expected and produces valid output. If possible, it'd also be nice to generalize common data manipulations used by readers so that we could ensure the code is working in just one location.

Background and Motivation

This stems from testing @jsolbrig and I performed on PR #427. When checking the output of B03Rad, we noticed that values of -999.8 still existed when reading from abi_netcdf. Further testing showed that all Rad channels had the same issue. Ref channels were fine, which makes this a bit confusing. Masking performed in that PR should be applied to all values less than or equal to -999.0, which didn't seem to occur here.

Code to demonstrate issue

geoips.plugins.modules.readers.abi_netcdf:get_data:1079 in PR #427.

Checklist for Completion

  • Check the output of masks for all readers
  • Fix problems if they exist
  • Considering abstracting masking code to a singular location to be used by all readers instead. This would improve maintainability and would reduce code duplication where applicable.
@evrose54 evrose54 added bug Something isn't working testing Test datasets, scripts, and processes discussion required This issue requires discussion before implementation potential bug Functionality that is working but maybe not as expected. Need to investigate further. labels Oct 23, 2024
@evrose54 evrose54 added this to the 2.0 milestone Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working discussion required This issue requires discussion before implementation potential bug Functionality that is working but maybe not as expected. Need to investigate further. testing Test datasets, scripts, and processes
Projects
None yet
Development

No branches or pull requests

1 participant