Merge pull request #872 from amgleitman/amgleitman/macos-accessibility-focus-notification

amgleitman · web-flow · commit 4baf0f30e8c9 · 2021-10-28T12:01:59.000-07:00
fix: Post NSAccessibilityLayoutChangedNotification when we call setAccessibilityFocus on macOS
diff --git a/React/Modules/MacOS/RCTAccessibilityManager.m b/React/Modules/MacOS/RCTAccessibilityManager.m
@@ -99,9 +99,10 @@ - (void)dealloc
 
 RCT_EXPORT_METHOD(setAccessibilityFocus:(nonnull NSNumber *)reactTag)
 {
-   dispatch_async(dispatch_get_main_queue(), ^{
+  dispatch_async(dispatch_get_main_queue(), ^{
     NSView *view = [self.bridge.uiManager viewForReactTag:reactTag];
     [[view window] makeFirstResponder:view];
+    NSAccessibilityPostNotification(view, NSAccessibilityLayoutChangedNotification);
   });
 }
 

Original file line number	Diff line number	Diff line change
`@@ -99,9 +99,10 @@ - (void)dealloc`
`99`	`99`
`100`	`100`	`RCT_EXPORT_METHOD(setAccessibilityFocus:(nonnull NSNumber *)reactTag)`
`101`	`101`	`{`
`102`		`- dispatch_async(dispatch_get_main_queue(), ^{`
	`102`	`+ dispatch_async(dispatch_get_main_queue(), ^{`
`103`	`103`	`NSView *view = [self.bridge.uiManager viewForReactTag:reactTag];`
`104`	`104`	`[[view window] makeFirstResponder:view];`
	`105`	`+ NSAccessibilityPostNotification(view, NSAccessibilityLayoutChangedNotification);`
`105`	`106`	`});`
`106`	`107`	`}`
`107`	`108`