Disable a bugprone-move-forwarding-reference error when running static analysis against jsi.h (#934)

anandrajeswaran · web-flow · commit 4aa5fd2f26d5 · 2021-12-20T16:29:46.000-08:00
diff --git a/ReactCommon/jsi/jsi/jsi.h b/ReactCommon/jsi/jsi/jsi.h
@@ -937,7 +937,9 @@ class JSI_EXPORT Value {
             std::is_base_of<String, T>::value ||
             std::is_base_of<Object, T>::value,
         "Value cannot be implicitly move-constructed from this type");
+#ifndef __clang_analyzer__ // TODO(macOS GH#774) Disable [bugprone-move-forwarding-reference] when running clang static analysis
     new (&data_.pointer) T(std::move(other));
+#endif // __clang_analyzer__
   }
 
   /// Value("foo") will treat foo as a bool.  This makes doing that a

Original file line number	Diff line number	Diff line change
`@@ -937,7 +937,9 @@ class JSI_EXPORT Value {`
`937`	`937`	`std::is_base_of<String, T>::value \|\|`
`938`	`938`	`std::is_base_of<Object, T>::value,`
`939`	`939`	`"Value cannot be implicitly move-constructed from this type");`
	`940`	`+#ifndef __clang_analyzer__ // TODO(macOS GH#774) Disable [bugprone-move-forwarding-reference] when running clang static analysis`
`940`	`941`	`new (&data_.pointer) T(std::move(other));`
	`942`	`+#endif // __clang_analyzer__`
`941`	`943`	`}`
`942`	`944`
`943`	`945`	`/// Value("foo") will treat foo as a bool. This makes doing that a`