Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration validation fails in strict_mode when files that aren't needed at runtime are specified #799

Closed
aaraney opened this issue Jul 8, 2024 · 0 comments · Fixed by #802

Comments

@aaraney
Copy link
Member

aaraney commented Jul 8, 2024

Configuration validation fails in strict mode in cases when a user wouldn't expect it to. I think this is best illustrated by example:

compute_parameters:
  data_assimilation_parameters:
      reservoir_rfc_da:
        reservoir_rfc_forecasts: false
        # ...
        reservoir_rfc_forecasts_time_series_path: rfc_timeseries/ # <- this is the issue

Validation in strict mode would fail if rfc_timeseries/ does not exist. Given that reservoir_rfc_forecasts is false I wouldn't expect that t-route would care that a file or directory does not exist if it is not going to be used. This was not a use case I was thinking about when I wrote configuration strict mode, but I do think its something that troute.config should support.

Ill start looking into potential avenues of how to address this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant