Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong python version used in workflow #377

Closed
hellkite500 opened this issue Feb 2, 2022 · 1 comment · Fixed by #379
Closed

Wrong python version used in workflow #377

hellkite500 opened this issue Feb 2, 2022 · 1 comment · Fixed by #379
Assignees
@hellkite500 @mattw-nws
Labels
bug Something isn't working CI/CD

Comments

@hellkite500
Copy link
Member

hellkite500 commented Feb 2, 2022 •
edited
Loading

ngen/.github/workflows/test_and_validate.yml

Line 681 in 1b79889

python -m venv .venv

python in this case is referencing python 2.7, which won't work for this test. This should be python3. This appears to be a regressing in the macos runner used for the mac tests...
@hellkite500 hellkite500 added bug Something isn't working CI/CD labels Feb 2, 2022
@hellkite500
Copy link
Member Author

might be worth changing the ubuntu tests to use python3 just for consistency (and to avoid future copy/paste issues???)

@mattw-nws mattw-nws mentioned this issue Feb 3, 2022
Merged
11 tasks
@hellkite500 hellkite500 linked a pull request Feb 3, 2022 that will close this issue
Fix workflow failure from wrong python version #379
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hellkite500 hellkite500

@mattw-nws mattw-nws

Labels
bug Something isn't working CI/CD
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix workflow failure from wrong python version NOAA-OWP/ngen
2 participants
@hellkite500 @mattw-nws