Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Destroy instance variables that hold ESMF objects on finalize() #14

Closed
program-- opened this issue Mar 15, 2024 · 0 comments
Closed

Destroy instance variables that hold ESMF objects on finalize() #14

program-- opened this issue Mar 15, 2024 · 0 comments

Comments

@program--
Copy link
Contributor

When NWMv3_Forcing_Engine_BMI_model.finalize() is called, the instance variables: _WrfHydroGeoMeta, _inputForcingMod, and _suppPcpMod should be destroyed. This is to ensure their destructors are not called after MPI_Finalize has been called elsewhere (specifically in relation to NOAA-OWP/ngen#748).

Current behavior

NWMv3_Forcing_Engine_BMI_model.finalize only clears scratch files and unsets the instance's model reference.

Expected behavior

NWMv3_Forcing_Engine_BMI_model.finalize should have:

del self._WrfHydroGeoMeta
del self._inputForcingMod
del self._suppPcpMod

in its body.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant