Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Job implementation for use of model_request attribute's output_formats #656

Open
robertbartel opened this issue Jun 11, 2024 · 0 comments
Labels
bug Something isn't working maas MaaS Workstream

Comments

@robertbartel
Copy link
Contributor

The Job class is implemented with a model_request property of hinted type ExternalRequest. There are calls in a couple of places in python/services/dataservice/dmod/dataservice/service.py to job.model_request.output_formats, but ExternalRequest does not have an output_formats attribute/property.

This property is actually defined in DmodJobRequest. It seems that most use cases for the data service have involved model_request objects that are both ExternalRequest and DmodJobRequest, but this needs to be either guaranteed/asserted or the design needs to be properly generalized.

@robertbartel robertbartel added bug Something isn't working maas MaaS Workstream labels Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working maas MaaS Workstream
Projects
None yet
Development

No branches or pull requests

1 participant