Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create dmod.communication.constants module #351

Open
aaraney opened this issue Jun 7, 2023 · 0 comments
Open

Create dmod.communication.constants module #351

aaraney opened this issue Jun 7, 2023 · 0 comments

Comments

@aaraney
Copy link
Member

aaraney commented Jun 7, 2023

In @christophertubbs's review of #331, he found several instances of duplicate information that is more appropriately captured in a constants module. This included fields like DEFAULT_SCHEDULER_MEMORY. When separating the communication package (#332), we should also create constants modules where appropriate.

Blocked by #331.
@aaraney aaraney mentioned this issue Jun 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aaraney