Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed unnecessary __init__ methods on Serializeable subtypes #346

Open
aaraney opened this issue Jun 6, 2023 · 1 comment
Open

Removed unnecessary __init__ methods on Serializeable subtypes #346

aaraney opened this issue Jun 6, 2023 · 1 comment
Labels
enhancement New feature or request maas MaaS Workstream

Comments

@aaraney
Copy link
Member

aaraney commented Jun 6, 2023

Post #331, it is a good idea for us to audit Serializable subtypes and remove __init__ methods where we can. #331 added complexity to many of the existing __init__ methods for the sake of backwards compatibility. However, there are few places that we programmatically create Serializable subtypes.
@robertbartel robertbartel added enhancement New feature or request maas MaaS Workstream labels Jun 7, 2023
@robertbartel
Copy link
Contributor

Blocked until #331 is fully merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request maas MaaS Workstream
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@robertbartel @aaraney