Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong calendar sometimes used in nudging. #155

Closed
menzel-gfdl opened this issue Oct 8, 2021 · 3 comments
Closed

Wrong calendar sometimes used in nudging. #155

menzel-gfdl opened this issue Oct 8, 2021 · 3 comments

Comments

@menzel-gfdl
Copy link
Contributor

menzel-gfdl commented Oct 8, 2021

Describe the bug
The calendar variable should be changed to "calendar" on this line:

if( variable_att_exists(fileobj, time_axis, calendar) ) then

This is causing the calendar attribute to not be read in the file, possibly leading to the wrong calendar being used in the run.

To Reproduce
Try any nudging run where the calendar attribute on the time axis is not gregorian.

Expected behavior
The correct calendar type should be used.

System Environment
This will probably happen on all systems.

Additional context

@menzel-gfdl
Copy link
Contributor Author

menzel-gfdl commented Oct 8, 2021

@bensonr @laurenchilutti Do you agree? Should I make a pull request?

@laurenchilutti
Copy link
Contributor

@menzel-gfdl I agree with what you are saying. Good catch! I am fine with you putting in a pull request for this.

@menzel-gfdl menzel-gfdl mentioned this issue Oct 8, 2021
6 tasks
@laurenchilutti
Copy link
Contributor

Fixed by PR #157

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants