Allow building of the ufs-weather-model, WW3 pre/post execs for GFS, GEFS, SFS in the same clone of global-workflow #3098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
aerorahul
changed the title
|
I am going to mark this as ready for review to gather feedback on the code changes before I commence extensive testing. |
aerorahul
requested review from
JessicaMeixner-NOAA,
sbanihash,
WalterKolczynski-NOAA,
DavidHuber-NOAA,
KateFriedman-NOAA and
TerrenceMcGuinness-NOAA
as code owners
WalterKolczynski-NOAA
added
CI-Wcoss2-Running
emcbot
added
CI-Hera-Building
|
Will run CI on Hercules as well once the PRs already running there have completed. |
emcbot
added
CI-Hera-Running
|
CI Passed on Hera in Build# 1 |
WalterKolczynski-NOAA
added
the
CI-Hercules-Ready
emcbot
added
CI-Hercules-Building
emcbot
added
CI-Hercules-Running
|
CI Passed on Hercules in Build# 2 |
WalterKolczynski-NOAA
approved these changes
Dec 16, 2024
This was referenced Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
GFS and GEFS (and now SFS) uses different compile time options for the UFS-weather-model. For the purposes of CI testing, a multi-build pipeline under Jenkins was created by @TerrenceMcGuinness-NOAA. This served well, until now. With the inclusion of SFS, a third variety of the model is being built. Under the multi-build pipeline paradigm, a second (or third) clone and build of the global-workflow is required. This adds cloning and compilation time of the global-workflow.
This PR allows compiling the ufs-weather-model in a single clone of the global-workflow. The compiled executables based on the options for GFS, GEFS, and SFS results in a model executable as
gfs_model.x,gefs_model.x, andsfs_model.x. The forecast script uses the right executable.This PR also differentiates the WW3 pre/post executables based on
gfs_orgefs_. SFS variants need to be introduced, whenNET=sfsis added.In the process of updating the WW3 pre/post executable names, it was discovered (via
grep) the following are not used:ww3_prepww3_outfww3_ounfww3_ounpThese need to be confirmed by running the workflow to ensure they are indeed not used at runtime.
This PR also updates the
Jenkinsfileto use the multi-build from the single location.Type of change
Change characteristics
This PR does not update any submodules.
How has this been tested?
In progress
Checklist