-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JCB-based obs+bias staging and fully move init+exec codes from Task to Jedi class #2992
Open
DavidNew-NOAA
wants to merge
76
commits into
NOAA-EMC:develop
Choose a base branch
from
DavidNew-NOAA:feature/jcb-obsbias
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
JCB-based obs+bias staging and fully move init+exec codes from Task to Jedi class #2992
DavidNew-NOAA
wants to merge
76
commits into
NOAA-EMC:develop
from
DavidNew-NOAA:feature/jcb-obsbias
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e bias correction files from tarball (NOAA-EMC#2862)
…on files using jedi class (NOAA-EMC#2862)
…ns analysis scripts (NOAA-EMC#2862)
This was referenced Oct 8, 2024
I'm leaving this PR as draft until the companion GDASApp PR is merged, but it is ready for review otherwise. cc @aerorahul @WalterKolczynski-NOAA @RussTreadon-NOAA |
CoryMartin-NOAA
pushed a commit
to NOAA-EMC/jcb-gdas
that referenced
this pull request
Oct 9, 2024
This PR is a companion to Global Workflow PR [#2992](NOAA-EMC/global-workflow#2992) and GDASApp PR [#1312](NOAA-EMC/GDASApp#1312). It add observation and bias files staging templates required for the above Global Workflow PR.
CoryMartin-NOAA
pushed a commit
to NOAA-EMC/GDASApp
that referenced
this pull request
Oct 15, 2024
This PR is a companion to Global-Workflow PR [#2992](NOAA-EMC/global-workflow#2992) and JCB-GDAS PR [#31](NOAA-EMC/jcb-gdas#31). It adds two parameters required for the above Global-Workflow PR to the JCB base YAML for the atmosphere.
@aerorahul @WalterKolczynski-NOAA @RussTreadon-NOAA With all companion PRs now merged, I'm marking this ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a companion to GDASApp PR #1312 and JCB-GDAS PR #31.
This PR does four things:
initialize_jedi
andexecute
methods from theAtmAnalysis
andAtmEnsAnalysis
classes and has that functionality handled directly by theJedi
class. This removes a lot of redundant code from the analysis classes.Jedi
constructor now takes as input a dictionary that is a subset of thetask_config
dictionary. This makes the code clearer and less opaque and makes debugging easier.AtmAnalysis
andAtmEnsAnalysis
. Before, in theatmensanl*
jobs for example, the LETKF solver was initialized in theatmensanlinit
cjob, but the LETKF solver and FV3 increment converter were both initialized and executed in theatmensanlobs
andatmensanlfv3inc
jobs respectively. This was because theJedi
class was looking for theJEDIEXE
,JCB_ALGO_YAML
, etc environment variables, which could only hold information for one application per job. Now, there are variables calledJEDIEXE_OBS
,JEDIEXE_SOL
,JEDIEXE_FV3INC
, etc which are specified in the input dictionary for theJedi
class constructor, all performed inatmensanlinit
. This not only makes more sense in terms of resources allocation for jobs, but it also makes the code less opaque.Type of change
Change characteristics
How has this been tested?
C96C48_ufs_hybatmDA CI runs successfully
GDASApp jjob tests pass successfully
Checklist