Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gdas build on Gaea and add Gaea to available CI list #2857

Merged
merged 2 commits into from
Aug 27, 2024
Merged

Fix gdas build on Gaea and add Gaea to available CI list #2857

merged 2 commits into from
Aug 27, 2024

Conversation

AnilKumar-NOAA
Copy link
Contributor

@AnilKumar-NOAA AnilKumar-NOAA commented Aug 22, 2024 •
edited
Loading

Description

Module git-lfs is required to run CI test on gaea machine and added gaea in the Jenkinsfile

  • Module (git-lfs) added in the modulefiles/module_gwsetup.gaea.lua
  • Gaea added (Jenkinsfile)

Type of change

  • Bug fix (fixes something broken)
  • New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? YES/NO
  • Does this change require a documentation update? YES/NO
  • Does this change require an update to any of the following submodules? YES/NO (If YES, please add a link to any PRs that are pending.)
    • EMC verif-global
    • GDAS
    • GFS-utils
    • GSI
    • GSI-monitor
    • GSI-utils
    • UFS-utils
    • UFS-weather-model
    • wxflow

How has this been tested?

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • I have made corresponding changes to the documentation if necessary

@AnilKumar-NOAA AnilKumar-NOAA changed the title module load git-lfs for CI Testing module load git-lfs & Jenkinsfile for CI Testing Aug 22, 2024
@TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA added the CI/CD Issue related to CI/CD label Aug 23, 2024
WalterKolczynski-NOAA
WalterKolczynski-NOAA requested changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@WalterKolczynski-NOAA WalterKolczynski-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully, the usage of git at build-time will be removed from jedi soon.

Please restore the current gdas and ufs versions. Also, try to figure out why this keeps happening (you shouldn't be doing a git add on these directories if you aren't changing them).

@WalterKolczynski-NOAA WalterKolczynski-NOAA changed the title module load git-lfs & Jenkinsfile for CI Testing Fix gdas build on Gaea and add Gaea to available CI list Aug 26, 2024
@AnilKumar-NOAA
Copy link
Contributor Author

AnilKumar-NOAA commented Aug 27, 2024 •
edited
Loading

Hopefully, the usage of git at build-time will be removed from jedi soon.

Please restore the current gdas and ufs versions. Also, try to figure out why this keeps happening (you shouldn't be doing a git add on these directories if you aren't changing them).

Walter - I corrected and just keeping the changes which need to be merged. Will take care that these will not happened in future. Thanks

@WalterKolczynski-NOAA WalterKolczynski-NOAA merged commit 935ac64 into NOAA-EMC:develop Aug 27, 2024
8 checks passed
DavidHuber-NOAA added a commit to DavidHuber-NOAA/global-workflow that referenced this pull request Aug 28, 2024
@DavidHuber-NOAA
Merge remote-tracking branch 'origin/develop' into fix/early_run_configs
473d47b 
* origin/develop:
  Fix gdas build on Gaea and add Gaea to available CI list (NOAA-EMC#2857)
  Support ATM forecast only on Google (NOAA-EMC#2832)
  Add GEFS C48 support on AWS (NOAA-EMC#2818)
  Update omega calculation (NOAA-EMC#2751)
  Add snow DA update and recentering for the EnKF forecasts (NOAA-EMC#2690)
DavidHuber-NOAA added a commit to DavidHuber-NOAA/global-workflow that referenced this pull request Sep 9, 2024
@DavidHuber-NOAA
Merge remote-tracking branch 'origin/develop' into feature/ss_180
386a940 
* origin/develop:
  Create JEDI class (NOAA-EMC#2805)
  Restructure the bufr sounding job    (NOAA-EMC#2853)
  Add an archive task to GEFS system to archive files locally (NOAA-EMC#2816)
  Reenable Orion Cycling Support (NOAA-EMC#2877)
  Eliminate race conditions and remove DATAROOT last in cleanup (NOAA-EMC#2893)
  Update aerosol climatology to 2013-2024 mean (NOAA-EMC#2888)
  Add ability to run CI test C96_atm3DVar.yaml to Gaea-C5 (NOAA-EMC#2885)
  Support global-workflow GEFS C48 on Google Cloud (NOAA-EMC#2861)
  Add 3 and 9 hr increment files to IC staging (NOAA-EMC#2876)
  Add diffusion/diag B for aerosol DA and some other needed changes (NOAA-EMC#2738)
  Correct ocean `MOM.res_#` stage copy (NOAA-EMC#2868)
  Support coupling on AWS (NOAA-EMC#2859)
  Add JEDI ATM lgetkf observer and solver jobs (NOAA-EMC#2833)
  Fix gdas build on Gaea and add Gaea to available CI list (NOAA-EMC#2857)
  Support ATM forecast only on Google (NOAA-EMC#2832)
  Add GEFS C48 support on AWS (NOAA-EMC#2818)
  Update omega calculation (NOAA-EMC#2751)
  Add snow DA update and recentering for the EnKF forecasts (NOAA-EMC#2690)
  support ATM forecast only on Azure (NOAA-EMC#2827)
  Convert staging job to python and yaml (NOAA-EMC#2651)
  Fixed test on UNAVAILBLE in python Rocoto check (NOAA-EMC#2842)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WalterKolczynski-NOAA WalterKolczynski-NOAA WalterKolczynski-NOAA approved these changes

Assignees
No one assigned
Labels
CI/CD Issue related to CI/CD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AnilKumar-NOAA @WalterKolczynski-NOAA @TerrenceMcGuinness-NOAA