Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UFSDA Land for COM refactor #1520

Closed
WalterKolczynski-NOAA opened this issue Apr 25, 2023 · 2 comments
Closed

Update UFSDA Land for COM refactor #1520

WalterKolczynski-NOAA opened this issue Apr 25, 2023 · 2 comments
Assignees

Comments

@WalterKolczynski-NOAA
Copy link
Contributor

WalterKolczynski-NOAA commented Apr 25, 2023

Description
UFSDA jobs were not included in the initial COM refactor work (#1421). These jobs will all need to be updated to use the new structure and templates before they can run again.

Requirements
UFSDA land analysis jobs that utilize the new COM templates to generate COM directory paths.

Acceptance Criteria (Definition of Done)
UFSDA land analysis jobs that work as well as before the COM refactor

(Optional): Suggest A Solution
There are two approaches we can take. The first is to define the full paths in the j-job using the templates, as is done for most of the existing global-workflow jobs, and update the python to expect full paths (with dates and cycles). The second is to use the templates directly in the python (reading the *_TMPL variables from the environment) and using Rahul's Template class to fill in the variables.

Recommend the first for now where feasible, though the latter may be needed if iterating over members in python (similar to how the EnKF exscripts have to do it). The Template class will need a minor update to proceed with option 2: The templates reply on the bash substitution replacing undefined variables with an empty string (mainly to replacing $MEMDIR for the deterministic files), but the class currently leaves any variables it doesn't have substitutions for as-is. It will need to be updated to provide the option to replace undefined variables with an empty string.

@jiaruidong2017
Copy link
Contributor

This is done and merged to the develop at #1564

@aerorahul
Copy link
Contributor

closed via #1564

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants